From 6bc5a46c55232b71f2ca93f698c2417a5c966b95 Mon Sep 17 00:00:00 2001 From: Clement Rey Date: Mon, 16 Dec 2024 19:26:20 +0100 Subject: [PATCH] fix the partial update checklist (-> topic) --- crates/store/re_chunk_store/src/query.rs | 6 +++++- .../check_range_partial_updates.py | 18 ++++++++++++++++-- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/crates/store/re_chunk_store/src/query.rs b/crates/store/re_chunk_store/src/query.rs index 228e4c601b51..e21380831df8 100644 --- a/crates/store/re_chunk_store/src/query.rs +++ b/crates/store/re_chunk_store/src/query.rs @@ -755,7 +755,11 @@ impl ChunkStore { }) .collect_vec(); - debug_assert!(chunks.iter().map(|chunk| chunk.id()).all_unique()); + debug_assert!( + chunks.iter().map(|chunk| chunk.id()).all_unique(), + "{:?}", + self.id() + ); chunks } diff --git a/tests/python/release_checklist/check_range_partial_updates.py b/tests/python/release_checklist/check_range_partial_updates.py index 39220eaf58d7..1d738c1e4a23 100644 --- a/tests/python/release_checklist/check_range_partial_updates.py +++ b/tests/python/release_checklist/check_range_partial_updates.py @@ -117,7 +117,14 @@ def log_points() -> None: rr.log("points", [rr.components.RadiusBatch(-20)]) rr.set_time_sequence("frame", 44) - rr.log("points", [rr.components.ColorBatch([0, 0, 255])]) + rr.log( + "points", + [ + rr.components.ColorBatch([0, 0, 255]).with_descriptor_overrides( + archetype_name=rr.Points3D.archetype_name(), archetype_field_name="colors" + ) + ], + ) rr.set_time_sequence("frame", 45) rr.log("points", rr.Points3D([[0, 0, 1], [1, 1, 0]])) @@ -127,7 +134,14 @@ def log_points() -> None: rr.log("points", [rr.components.RadiusBatch(-40)]) rr.log("points", rr.Points3D([[0, 2, 0], [1, 2, 1]])) rr.log("points", [rr.components.RadiusBatch(-30)]) - rr.log("points", [rr.components.ColorBatch([0, 255, 0])]) + rr.log( + "points", + [ + rr.components.ColorBatch([0, 255, 0]).with_descriptor_overrides( + archetype_name=rr.Points3D.archetype_name(), archetype_field_name="colors" + ) + ], + ) rr.log("points", rr.Points3D([[0, 0, 2], [2, 2, 0]]))