From 62943344856bb2c734607e95d3671e3adae4ef2c Mon Sep 17 00:00:00 2001
From: Andreas Reich <andreas@rerun.io>
Date: Fri, 11 Oct 2024 17:58:26 +0200
Subject: [PATCH] add a comment pointing to how common it is to change colors
 depending on

---
 crates/store/re_video/src/decode/av1.rs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/crates/store/re_video/src/decode/av1.rs b/crates/store/re_video/src/decode/av1.rs
index db663b1b58ce..61c29e2a0f4f 100644
--- a/crates/store/re_video/src/decode/av1.rs
+++ b/crates/store/re_video/src/decode/av1.rs
@@ -254,6 +254,9 @@ fn color_primaries(debug_name: &str, picture: &dav1d::Picture) -> ColorPrimaries
                 //     ColorPrimaries::Bt601
                 // }
                 //
+                // This is also what the mpv player does (and probably others):
+                // https://wiki.x266.mov/docs/colorimetry/primaries#2-unspecified
+                //
                 // …then again, eyeballing VLC it looks like it just always assumes BT.709.
                 // The handwavy test case employed here was the same video in low & high resolution
                 // without specified primaries. Both looked the same.