From 3888dab755c572897433038fe6f92893085b8276 Mon Sep 17 00:00:00 2001 From: Andreas Reich Date: Wed, 9 Oct 2024 19:07:45 +0200 Subject: [PATCH] typo fixes --- .../viewer/re_renderer/src/resource_managers/yuv_converter.rs | 4 ++-- .../viewer/re_viewer_context/src/gpu_bridge/image_to_gpu.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs b/crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs index af2c6f60a27f4..7606ee6be032a 100644 --- a/crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs +++ b/crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs @@ -15,11 +15,11 @@ use super::ColorPrimaries; /// Supported chroma subsampling input formats. /// -/// We use `YUV`/`YCbCr`/`YPbPr` interchangably and usually just call it `YUV`. +/// We use `YUV`/`YCbCr`/`YPbPr` interchangeably and usually just call it `YUV`. /// /// According to this [source](https://www.retrosix.wiki/yuv-vs-ycbcr-vs-rgb-color-space/): /// * `YUV` is an analog signal -/// * `YCbCr` is scaled and offseted version of YUV, used in digital signals (we denote this as "limited range YUV") +/// * `YCbCr` is scaled and offsetted version of YUV, used in digital signals (we denote this as "limited range YUV") /// * `YPbPr` is the physical component cabel to transmit `YCbCr` /// Actual use in the wild seems to be all over the place. /// For instance `OpenCV` uses `YCbCr` when talking about the full range and YUV when talking about diff --git a/crates/viewer/re_viewer_context/src/gpu_bridge/image_to_gpu.rs b/crates/viewer/re_viewer_context/src/gpu_bridge/image_to_gpu.rs index acf048df35482..5f7efd031c8ee 100644 --- a/crates/viewer/re_viewer_context/src/gpu_bridge/image_to_gpu.rs +++ b/crates/viewer/re_viewer_context/src/gpu_bridge/image_to_gpu.rs @@ -256,7 +256,7 @@ pub fn texture_creation_desc_from_color_image<'a>( let format = match pixel_format { // For historical reasons, using Bt.709 for fully planar formats and Bt.601 for others. // - // TODO(andreas): Investigate if there's underlying expecation for some of these (for instance I suspect that NV12 is "usually" BT601). + // TODO(andreas): Investigate if there's underlying expectation for some of these (for instance I suspect that NV12 is "usually" BT601). // TODO(andreas): Expose color primaries. It's probably still the better default (for instance that's what jpeg still uses), // but should confirm & back that up! //