From 285797e667361385ca518538c02ed6039b142570 Mon Sep 17 00:00:00 2001 From: Antoine Beyeler Date: Mon, 16 Dec 2024 19:05:44 +0100 Subject: [PATCH] Fix context menu release checklist formating and casing of the `Hide/Show all` item --- crates/viewer/re_context_menu/src/actions/show_hide.rs | 4 ++-- .../check_context_menu_multi_selection.py | 4 ++-- .../check_context_menu_single_selection.py | 10 ++++++++-- ...eck_context_menu_single_selection_blueprint_tree.py | 5 ++++- 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/crates/viewer/re_context_menu/src/actions/show_hide.rs b/crates/viewer/re_context_menu/src/actions/show_hide.rs index b952b62889a0..b183e03108be 100644 --- a/crates/viewer/re_context_menu/src/actions/show_hide.rs +++ b/crates/viewer/re_context_menu/src/actions/show_hide.rs @@ -26,7 +26,7 @@ impl ContextMenuAction for ShowAction { fn label(&self, ctx: &ContextMenuContext<'_>) -> String { if ctx.selection.len() > 1 { - "Show All".to_owned() + "Show all".to_owned() } else { "Show".to_owned() } @@ -80,7 +80,7 @@ impl ContextMenuAction for HideAction { fn label(&self, ctx: &ContextMenuContext<'_>) -> String { if ctx.selection.len() > 1 { - "Hide All".to_owned() + "Hide all".to_owned() } else { "Hide".to_owned() } diff --git a/tests/python/release_checklist/check_context_menu_multi_selection.py b/tests/python/release_checklist/check_context_menu_multi_selection.py index 68f47c6ee008..8864588a4fd4 100644 --- a/tests/python/release_checklist/check_context_menu_multi_selection.py +++ b/tests/python/release_checklist/check_context_menu_multi_selection.py @@ -17,7 +17,7 @@ ========================================================== ITEMS CONTEXT MENU CONTENT ========================================================== -2x Views Hide all +2x Views Hide all Remove Expand all @@ -38,7 +38,7 @@ Expand all Collapse all ========================================================== -View + 'box2d' data result Hide all +View + 'box2d' data result Hide all Remove Expand all diff --git a/tests/python/release_checklist/check_context_menu_single_selection.py b/tests/python/release_checklist/check_context_menu_single_selection.py index 8ff3f85dd682..14f7d5180281 100644 --- a/tests/python/release_checklist/check_context_menu_single_selection.py +++ b/tests/python/release_checklist/check_context_menu_single_selection.py @@ -42,9 +42,12 @@ ================================================= ITEM CONTEXT MENU CONTENT ================================================= -view (tab title) Hide +view (tab title) Hide Remove + Copy screenshot + Save screenshot… + Expand all Collapse all @@ -66,9 +69,12 @@ ================================================= ITEM CONTEXT MENU CONTENT ================================================= -view (child list) Hide +view (child list) Hide Remove + Copy screenshot + Save screenshot… + Expand all Collapse all diff --git a/tests/python/release_checklist/check_context_menu_single_selection_blueprint_tree.py b/tests/python/release_checklist/check_context_menu_single_selection_blueprint_tree.py index 6eb133482d43..4b5ab7a340f1 100644 --- a/tests/python/release_checklist/check_context_menu_single_selection_blueprint_tree.py +++ b/tests/python/release_checklist/check_context_menu_single_selection_blueprint_tree.py @@ -37,9 +37,12 @@ Move to new container ------------------------------------------------------------------ -View Hide (or Show, depending on visibility) +View Hide (or Show, depending on visibility) Remove + Copy screenshot + Save screenshot… + Expand all Collapse all