From 1bcd40b21470129c7d9ed127cf26337940862cdb Mon Sep 17 00:00:00 2001 From: Zeljko Mihaljcic <7150613+zehiko@users.noreply.github.com> Date: Mon, 4 Nov 2024 11:28:05 +0100 Subject: [PATCH] include separate rec id in the register metadata response --- .../re_remote_store_types/proto/rerun/v0/remote_store.proto | 1 + .../store/re_remote_store_types/src/v0/rerun.remote_store.v0.rs | 2 ++ 2 files changed, 3 insertions(+) diff --git a/crates/store/re_remote_store_types/proto/rerun/v0/remote_store.proto b/crates/store/re_remote_store_types/proto/rerun/v0/remote_store.proto index 510056293ec7..4455ec4c0903 100644 --- a/crates/store/re_remote_store_types/proto/rerun/v0/remote_store.proto +++ b/crates/store/re_remote_store_types/proto/rerun/v0/remote_store.proto @@ -34,6 +34,7 @@ message RecordingMetadata { } message RegisterRecordingResponse { + RecordingId id = 1; // Note / TODO(zehiko): this implies we read the record (for example go through entire .rrd file // chunk by chunk) and extract the metadata. So we might want to 1/ not do this i.e. // only do it as part of explicit GetMetadata request or 2/ do it if Request has "include_metadata=true" diff --git a/crates/store/re_remote_store_types/src/v0/rerun.remote_store.v0.rs b/crates/store/re_remote_store_types/src/v0/rerun.remote_store.v0.rs index 2208a0b82ef1..615cb9a32681 100644 --- a/crates/store/re_remote_store_types/src/v0/rerun.remote_store.v0.rs +++ b/crates/store/re_remote_store_types/src/v0/rerun.remote_store.v0.rs @@ -269,6 +269,8 @@ pub struct RecordingMetadata { } #[derive(Clone, PartialEq, ::prost::Message)] pub struct RegisterRecordingResponse { + #[prost(message, optional, tag = "1")] + pub id: ::core::option::Option, /// Note / TODO(zehiko): this implies we read the record (for example go through entire .rrd file /// chunk by chunk) and extract the metadata. So we might want to 1/ not do this i.e. /// only do it as part of explicit GetMetadata request or 2/ do it if Request has "include_metadata=true"