Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues that don't have status recieved should not be displayed in the requests list #3601

Open
PascalRepond opened this issue Feb 15, 2024 · 1 comment
Open

Issues that don't have status recieved should not be displayed in the requests list #3601

PascalRepond opened this issue Feb 15, 2024 · 1 comment
Labels
effort: minor Solved quickly enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Feb 15, 2024 •
edited
Loading

How it works

Currently, serial issues that don't have the status recieved are not displayed in the public UI but they can still be requested in the API/pro UI and are then displayed in the requests lists in the pro UI.

As these issues do not exist physically yet, they should not be shown in the requests lists when requested (same as an item that is already on loan or in transit).

Improvement suggestion

Filter out item/issues that do not have the status "recieved" to be displayed in the pro requests list.

  • Either automatically validate requests on items/issues with a specific status in the backend so that they are LoanState.IN_TRANSIT_FOR_PICKUP, and are not shown in this list
  • Or use the item data in the ui to filter out (ONLY IN THIS LIST) the loans for these items.
@PascalRepond PascalRepond added the enhancement Improvement of an existing feature label Feb 15, 2024
@PascalRepond PascalRepond added effort: minor Solved quickly f: circulation Concerns the circulation interface or backend labels Feb 15, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Feb 15, 2024
@PascalRepond PascalRepond moved this from Product Backlog to Inbox in RERO ILS issues Feb 29, 2024
@PascalRepond PascalRepond added the wontfix This issue will not be addressed label Mar 11, 2024
@PascalRepond PascalRepond closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done in RERO ILS issues Mar 11, 2024
@PascalRepond PascalRepond reopened this May 15, 2024
@github-project-automation github-project-automation bot moved this from Done to Product Backlog in RERO ILS issues May 15, 2024
@PascalRepond PascalRepond changed the title Block request for issues that don't have status recieved Issues that don't have status recieved should not be displayed in the requests list May 15, 2024
@PascalRepond PascalRepond removed the wontfix This issue will not be addressed label May 15, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Nov 12, 2024
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: minor Solved quickly enhancement Improvement of an existing feature f: circulation Concerns the circulation interface or backend
Projects
RERO ILS issues
Status: Product Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PascalRepond