Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minSockets confusion #8

Open
egirshov opened this issue May 8, 2013 · 0 comments
Open

minSockets confusion #8

egirshov opened this issue May 8, 2013 · 0 comments

Comments

@egirshov
Copy link

egirshov commented May 8, 2013

While using let's say ForeverAgent({maxSockets: 5}) is clear (allocate up to 5 sockets), in order to create a pool with exactly one socket I need to pass options {maxSockets: 1, minSockets: 2} as minSockets means something like "minimal amount of sockets to be kept in the pool" + 1.

Changing < to <= in https://github.com/mikeal/forever-agent/blob/master/index.js#L22 will fix it, however I understand that doing that will affect current users, so if that is not possible clarification in the doc will be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant