-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested settings support #487
base: main
Are you sure you want to change the base?
Conversation
added support for nested settings and fixed type for findInReactTree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent breaking changes, add a fallback as the original string with the dot included.
i dont get what you mean. if you think not including . will break for not nested settings then its not the case ig edit: i dont get what you mean after reading multiple times so can you elaborate or say in simpler terms |
If an addon is already relying on a key like |
How do I add that? Any ideas? |
Just add a fallback to use the initial behavior if the new behavior is undefined |
How do I decide if new behavior is undefined or not. What is the new behavior anyways |
❌ Deploy Preview for replugged-docs failed.
|
fixed types, and fallback value usage. also added a check if the key given is already in settings ignoring the path separator it will be treated as a key. |
added support for nested settings and fixed type for findInReactTree
this pr will close #383
sorry closed the old pr by mistake coz of renaming the branch. sorry