Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve minimumReleaseAge documentation and link to from renovate/stability-days builds #21013

Closed
setchy opened this issue Mar 17, 2023 · 9 comments · Fixed by #28378
Closed
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@setchy
Copy link
Collaborator

setchy commented Mar 17, 2023

What would you like Renovate to be able to do?

Create a dedicated documentation page to explain how Stability Days works.

Then use this new page as the hyperlink for the renovate/stability-days build, like those below

image

If you have any ideas on how this should be implemented, please tell us here.

create new docs page and update builds to reference it

Is this a feature you are interested in implementing yourself?

Maybe

@setchy setchy added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Mar 17, 2023
@setchy
Copy link
Collaborator Author

setchy commented Mar 17, 2023

Based off this discussion: #21008

@viceice viceice added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 17, 2023
@setchy
Copy link
Collaborator Author

setchy commented Mar 17, 2023

And this, more thoroughly documented discussion - #14948

@HonkingGoose
Copy link
Collaborator

create new docs page and update builds to reference it

We already have some stabilityDays config option docs 1. We could:

  • Trim the config option docs for stabilityDays so it only shows "basic configuration"
  • Create new "Key concepts, stability days" page
  • Move the full explanation to the new page

Footnotes

  1. stabilityDays config option docs

@rarkins
Copy link
Collaborator

rarkins commented Mar 18, 2023

Also keep in mind we would like to rename stabilityDays: #12914

So ideally don't name the file like "stability-days.md" so that its content can change later if necessary

@setchy setchy changed the title Stability Days documentation used ation and update stabilityDays builds to link to this documentation Improve Stability Days documentation link to from stabilityDays builds Mar 18, 2023
@setchy setchy changed the title Improve Stability Days documentation link to from stabilityDays builds Improve Stability Days documentation and link to from stabilityDays builds Mar 18, 2023
@HonkingGoose
Copy link
Collaborator

Also keep in mind we would like to rename stabilityDays: #12914

Thanks for reminding me! 😄

So ideally don't name the file like "stability-days.md" so that its content can change later if necessary

I read issue #12914 and I think you still need to decide on the new name for the overall concept of stabilityDays or minimumReleaseAge? I'm happy to start using the new name, once we decide what that name is. 😄

@setchy
Copy link
Collaborator Author

setchy commented Mar 22, 2023

I like the sound of minimumReleaseAge... Matches up OK with the merge confidence badges

@rarkins rarkins changed the title Improve Stability Days documentation and link to from stabilityDays builds Improve minimumReleaseAge documentation and link to from renovate/stability-days builds May 31, 2023
@HonkingGoose
Copy link
Collaborator

What we have now:

The original request of this issue was to:

Create a dedicated documentation page to explain how Stability Days works.

Do we still want/need a separate page?

The minimumReleaseAge config option docs explain:

  • That it was renamed from stabilityDays
  • Which conditions need to be met for Renovate to check the set duration
  • That Renovate waits for the set duration to pass for each separate version
  • That you can use selective-scheduling, and links to the docs for that concept
  • That Renovate adds a pending status check, and replaces it with a passing check when the minimumReleaseAge is met
  • That some datasources don't have a release timestamp, which means the feature does not work. Or that Renovate does not support a release timestamp for a datasource yet
  • Note for Maven users when Maven source has unreliable last-modified headers
  • Note admonition that configuring this option means you get a new status check: renovate/stability-days

And it covers some uses:

  • Suppress branch/PR creation for X days
  • Prevent holding broken npm packages
  • Await X time duration before Automerging

Discussion

It seems like we have a good starting point with the current minimumReleaseAge config option docs. @setchy can you take a look at what we have now, and explain what you think is missing?

@setchy
Copy link
Collaborator Author

setchy commented Apr 12, 2024

@HonkingGoose well summarized, great to see the progress on this.

I had a quick look at my use-cases and noticed two items

  1. Bitbucket Pipeline build (for branch status) is linked to https://docs.renovatebot.com/, not https://docs.renovatebot.com/configuration-options/#minimumreleaseage. This is true for all platforms. Raised feat(branch-status): use targeted doc links for merge confidence and minimum release age #28378 to address

  2. branch name defaults to renovate/stability-days - but looks to be configurable via https://docs.renovatebot.com/configuration-options/#statuschecknames

@HonkingGoose
Copy link
Collaborator

  1. branch name defaults to renovate/stability-days - but looks to be configurable via https://docs.renovatebot.com/configuration-options/#statuschecknames

We have an issue to rename the status check, that seems related?

The rename issue is blocked by this one:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
4 participants