Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent use of 24-hour / am-pm clock #192

Open
jsoref opened this issue Dec 18, 2023 · 0 comments
Open

inconsistent use of 24-hour / am-pm clock #192

jsoref opened this issue Dec 18, 2023 · 0 comments

Comments

@jsoref
Copy link

jsoref commented Dec 18, 2023

  1. Visit https://githubunwrapped.com/ghost
  2. Play through until you get to the frame that animates calculating the most productive time:
image

Note that the bar graph is going from 0..23 but the spinner is showing am/pm.

Expected results: one or the other time representation, but not both. (Personally, I prefer am/pm.)

That could mean showing 12a and 12p instead of 0 and 12 for those bar points (the a and p could be wrapped to second lines).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsoref