Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

CircleCI is red #88

Open
ionescu77 opened this issue Nov 26, 2019 · 3 comments
Open

CircleCI is red #88

ionescu77 opened this issue Nov 26, 2019 · 3 comments

Comments

@ionescu77
Copy link

some tests are failing
Screenshot 2019-11-26 at 10 54 27
Screenshot 2019-11-26 at 10 54 36
Screenshot 2019-11-26 at 10 54 55
Screenshot 2019-11-26 at 10 55 10

@ionescu77
Copy link
Author

ionescu77 commented Nov 26, 2019

Thanks @relekang , it's a good package we are using. I made a fork and will try to fix.
I guess it is just some stuff in tox.ini.
Releases:

# from circleci/config.yml
image: circleci/python:3.6

tox-3.14.1

flake8==3.7.9
mccabe==0.6.1
pycodestyle==2.5.0
pyflakes==2.1.1

Some sections need to be updated.

Strange I cannot assign to myself the issue :-/

@ionescu77
Copy link
Author

ionescu77 commented Nov 26, 2019

Ah ok:
./tests/models.py:4:5: F401 'django.contrib.auth.models.UserManager' imported but unused

#!/bin/bash -eo pipefail
tox -e flake8
flake8 installed: entrypoints==0.3,flake8==3.7.9,mccabe==0.6.1,pycodestyle==2.5.0,pyflakes==2.1.1
flake8 run-test-pre: PYTHONHASHSEED='1589985555'
flake8 run-test: commands[0] | flake8
./tests/models.py:4:5: F401 'django.contrib.auth.models.UserManager' imported but unused
ERROR: InvocationError for command /home/circleci/project/.tox/flake8/bin/flake8 (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   flake8: commands failed

ionescu77 added a commit to ionescu77/django-nopassword that referenced this issue Nov 26, 2019
@ionescu77
Copy link
Author

ionescu77 commented Nov 26, 2019

We can ignore F401, or per file ignore:

per-file-ignores =
    tests/models.py:4:5: F401

I need to take a break, but I'll read this and come back:

http://flake8.pycqa.org/en/latest/user/options.html?highlight=per-file-ignores#cmdoption-flake8-per-file-ignores

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant