Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early if publish = false in Cargo.toml and publish = true in release-plz configuration #1896

Open
MarcoIeni opened this issue Dec 8, 2024 · 0 comments
Open

Fail early if publish = false in Cargo.toml and publish = true in release-plz configuration #1896

MarcoIeni opened this issue Dec 8, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MarcoIeni
Copy link
Member

In the run function, add a validation to fail if the publish is Some([]) (which means in Cargo.toml it was publish = false) and publish in release-plz config is explicitly set to true.
@MarcoIeni MarcoIeni added enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2024
@MarcoIeni MarcoIeni mentioned this issue Dec 8, 2024
Draft
16 tasks
@MarcoIeni MarcoIeni added the help wanted Extra attention is needed label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcoIeni