-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release a first release? ("0.1.0") #89
Comments
Hi! Not sure if related with your issue. Can you try running https://github.com/ipvm-wg/homestar/blob/b0bda83236f946081aca99c62eb3b0c71f11312b/.github/workflows/release.yml#L53 in another job? Probably it's creating some files and so it leaves the directory dirty. |
@MarcoIeni sure on both fronts; however, in running release-plz locally, same config, w/
What do you think? Seems like if it happens locally it's another issue @MarcoIeni. |
Sorry for the delay, I'm at EuroRust and i didn't have time to look into this yet. I'll try to have a look this weekend. |
After #1036 and applying this change,
|
awesome and thank you @MarcoIeni. Will test this myself shortly. I'll add one fix to your PR there and merge. Thanks for being so helpful! |
Guessing you'll cut a new action release too to get the version update (if it works that way)? |
There are committed `png` files, so we don't want to ignore all of them, right? 🤔 Having files gitignored and committed confuses [release-plz](release-plz/action#89). Is this a common pattern? Usually I don't gitignore things I commit. Committed png files: `["assets/a_logo.png", "examples/websocket-relay/synthcat.png"]`. ## Alternative Remove the committed `.png`. Signed-off-by: Marco Ieni <[email protected]>
Yes, I'm on it 😎 |
released now. Enjoy! |
Extending on #14.
@MarcoIeni I'm suffering from a similar issue that includes way more uncommitted files (on a first release):
https://github.com/ipvm-wg/homestar/actions/runs/6464670097/job/17549663658#step:28:150
I've added https://github.com/ipvm-wg/homestar/blob/main/release-plz.toml, but avoided
allow-dirty
/publish-allow-dirty
, as it seems to want to capture things unrelated to the packages I actually want to release, i.e. all the top-level.md
's, dockers, examples. I'm probably just messing something up, and I know release-plz/release-plz#721 is not there yet; however, how would you suggest I go about this for a first release?Additionally, every variant of a PR I create seems to want to delete all the "uncommitted" files. I could fix this manually for the first release, maybe?
The text was updated successfully, but these errors were encountered: