Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a first release? ("0.1.0") #89

Closed
zeeshanlakhani opened this issue Oct 10, 2023 · 8 comments · Fixed by release-plz/release-plz#1036
Closed

Release a first release? ("0.1.0") #89

zeeshanlakhani opened this issue Oct 10, 2023 · 8 comments · Fixed by release-plz/release-plz#1036

Comments

@zeeshanlakhani
Copy link

zeeshanlakhani commented Oct 10, 2023

Extending on #14.

@MarcoIeni I'm suffering from a similar issue that includes way more uncommitted files (on a first release):

https://github.com/ipvm-wg/homestar/actions/runs/6464670097/job/17549663658#step:28:150

I've added https://github.com/ipvm-wg/homestar/blob/main/release-plz.toml, but avoided allow-dirty/publish-allow-dirty, as it seems to want to capture things unrelated to the packages I actually want to release, i.e. all the top-level .md's, dockers, examples. I'm probably just messing something up, and I know release-plz/release-plz#721 is not there yet; however, how would you suggest I go about this for a first release?

Additionally, every variant of a PR I create seems to want to delete all the "uncommitted" files. I could fix this manually for the first release, maybe?

@zeeshanlakhani zeeshanlakhani changed the title Release a 0.0.1 (first release)? Release a first release? Oct 10, 2023
@zeeshanlakhani zeeshanlakhani changed the title Release a first release? Release a first release? ("0.1.0") Oct 10, 2023
@MarcoIeni
Copy link
Member

Hi!
In https://github.com/ipvm-wg/homestar/blob/main/.github/workflows/release.yml I noticed that you are using rust-cache before installing the toolchain. But you should first install the toolchain and than use the cache from my understanding and their docs.

Not sure if related with your issue.

Can you try running https://github.com/ipvm-wg/homestar/blob/b0bda83236f946081aca99c62eb3b0c71f11312b/.github/workflows/release.yml#L53 in another job? Probably it's creating some files and so it leaves the directory dirty.
You can say that release-plz depends on the dry-run job.

@zeeshanlakhani
Copy link
Author

zeeshanlakhani commented Oct 10, 2023

@MarcoIeni sure on both fronts; however, in running release-plz locally, same config, w/ release-plz release-pr ..., I'm also getting the same set of uncommitted things (top-levels, etc). So, this is not just action related it seems.

Error: the working directory of this project has uncommitted changes. Please commit or stash these changes...

What do you think? Seems like if it happens locally it's another issue @MarcoIeni.

@MarcoIeni
Copy link
Member

Sorry for the delay, I'm at EuroRust and i didn't have time to look into this yet. I'll try to have a look this weekend.

@MarcoIeni
Copy link
Member

After #1036 and applying this change, release-plz update works locally:

$ release-plz update
...
$ git status
On branch main
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	homestar-core/CHANGELOG.md
	homestar-runtime/CHANGELOG.md
	homestar-wasm/CHANGELOG.md

nothing added to commit but untracked files present (use "git add" to track)

@zeeshanlakhani
Copy link
Author

awesome and thank you @MarcoIeni. Will test this myself shortly. I'll add one fix to your PR there and merge. Thanks for being so helpful!

@zeeshanlakhani
Copy link
Author

Guessing you'll cut a new action release too to get the version update (if it works that way)?

zeeshanlakhani pushed a commit to ipvm-wg/homestar that referenced this issue Oct 15, 2023
There are committed `png` files, so we don't want to ignore all of them,
right? 🤔

Having files gitignored and committed confuses
[release-plz](release-plz/action#89).
Is this a common pattern?
Usually I don't gitignore things I commit.

Committed png files: `["assets/a_logo.png",
"examples/websocket-relay/synthcat.png"]`.


## Alternative

Remove the committed `.png`.

Signed-off-by: Marco Ieni <[email protected]>
@MarcoIeni
Copy link
Member

Yes, I'm on it 😎
Should be ready in a couple of hours.

@MarcoIeni
Copy link
Member

released now. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants