Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add the Firecrest slurm scheduler #3046

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'feat/skip_module_init' of github.com:ekouts/reframe int…
…o firecrest_scheduler
ekouts committed Nov 30, 2023
commit feebb9e8a09332a6abac971d583e7d5d2ac57b6e
4 changes: 1 addition & 3 deletions reframe/core/modules.py
Original file line number Diff line number Diff line change
@@ -586,9 +586,9 @@ class TModImpl(ModulesSystemImpl):
MIN_VERSION = (3, 2)

def __init__(self, module_resolution=True):
self._version = None
if not module_resolution:
# The module system may not be available locally
self._version = None
return

# Try to figure out if we are indeed using the TCL version
@@ -725,7 +725,6 @@ class TMod31Impl(TModImpl):
def __init__(self, module_resolution=True):
self._version = None
self._command = None

if not module_resolution:
# The module system may not be available locally
return
@@ -1119,7 +1118,6 @@ class SpackImpl(ModulesSystemImpl):
def __init__(self, module_resolution=True):
self._name_format = '{name}/{version}-{hash}'
self._version = None

if not module_resolution:
# The module system may not be available locally
return
7 changes: 5 additions & 2 deletions reframe/core/systems.py
Original file line number Diff line number Diff line change
@@ -467,7 +467,8 @@ def __init__(self, name, descr, hostnames, modules_system,
self._name = name
self._descr = descr
self._hostnames = hostnames
self._modules_system = ModulesSystem.create(modules_system, module_resolution)
self._modules_system = ModulesSystem.create(modules_system,
module_resolution)
self._preload_env = preload_env
self._prefix = prefix
self._outputdir = outputdir
@@ -591,7 +592,9 @@ def create(cls, site_config):
resourcesdir=site_config.get('systems/0/resourcesdir'),
stagedir=site_config.get('systems/0/stagedir'),
partitions=partitions,
module_resolution=site_config.get('general/resolve_module_conflicts')
module_resolution=site_config.get(
'general/resolve_module_conflicts'
)
)

@property
You are viewing a condensed version of this merge commit. You can view the full changes here.