Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing -decoy option ends up sending a -1 generation number #73

Open
ewust opened this issue Sep 29, 2021 · 0 comments
Open

Providing -decoy option ends up sending a -1 generation number #73

ewust opened this issue Sep 29, 2021 · 0 comments

Comments

@ewust
Copy link
Member

ewust commented Sep 29, 2021

If the user specifies the -decoy option (e.g. ./cli -connect-addr=1.2.3.4:443 -decoy colorado.edu,128.138.129.98), then the registration that gets sent will not send the generation ID from the ClientConf, and the station will get a MAX_UINT generation ID.

While the documentation warns that -decoy will ignore the ClientConf, it's still getting a public key from it. Ideally, we should:

  1. add a -generation option to the CLI that overrides the ClientConf if it is provided
  2. use the ClientConf generation if the above option is not provided
  3. Error if none of the above are present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant