Fail build if commit naming convention is not met

[alenkacz]

There's a convention for commit naming - all commits should be prefixed with component/sub-component name. It would be nice to have this convention enforced so that it's easy to follow for new contributors.

We could use pre-commit hook or at least start with a github action validating that.

JIRA Link: CORE-583

[alenkacz]

@0xdiba any other ideas here? :)

[dotnwat]

Is pre-commit hooks an opt-in sort of thing? I create many commits that do not follow this rule during the development process.

[alenkacz]

hmm good point, that would probably not be a good idea. Maybe just something that's run in CI then? Found this, maybe we can reuse this or write something similar https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md

[dotnwat]

hmm good point, that would probably not be a good idea. Maybe just something that's run in CI then? Found this, maybe we can reuse this or write something similar https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md

yeh! good idea @alenkacz . i think we have at least a few unwritten style guidelines (e.g. prefix: subject is a good one) that would be easy enough to check in a github action, either enforcing a rule or maybe for some rules gently reminding about the guidelines but not blocking.

@ivotron ^ what do you think

[ivotron]

commitlint seems really cool! I think we should adopt it. I'll look deeper into it