config: iceberg_enabled should not be enterprise #24421

oleiman · 2024-12-03T17:59:16Z

For beta version, should not require a license.

Backports Required

Release Notes

Improvements

Beta version of Iceberg support was incorrectly classified as "enterprise only".

For beta version, should not require a license. Signed-off-by: Oren Leiman <[email protected]>

vbotbuildovich · 2024-12-03T20:03:37Z

the below tests from https://buildkite.com/redpanda/redpanda/builds/59186#01938db0-3aa7-4f78-8f4e-14d3cceb7e8e have failed and will be retried

gtest_raft_rpunit

vbotbuildovich · 2024-12-03T20:28:25Z

vbotbuildovich · 2024-12-03T20:28:48Z

Retry command for Build#59186

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":true}

vbotbuildovich · 2024-12-03T20:30:45Z

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59186#01938df2-0f7d-4fed-a3e1-5804cb5ee387:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_license_enforcement.clean_node_before_recovery=True.clean_node_after_recovery=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59186#01938df2-0f80-4b17-b204-78e3f1cfebf4:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_escape_hatch_license_variable.clean_node_before_upgrade=True"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59186#01938e0d-732e-487d-a34a-85f281d5b85f:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_license_enforcement.clean_node_before_recovery=True.clean_node_after_recovery=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59186#01938e0d-7331-44f6-b163-e1f2a4cf69a9:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_escape_hatch_license_variable.clean_node_before_upgrade=True"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59201#01938f20-7f43-4eeb-b9b3-378caf1eafb2:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_escape_hatch_license_variable.clean_node_before_upgrade=True"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59201#01938f20-7f41-4155-9b52-d59ff8b762ef:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_license_enforcement.clean_node_before_recovery=True.clean_node_after_recovery=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59201#01938f25-238e-431e-9037-fff33c0a97e0:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_license_enforcement.clean_node_before_recovery=True.clean_node_after_recovery=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59201#01938f25-2390-43a9-a16d-701929d63aad:

"rptest.tests.license_enforcement_test.LicenseEnforcementTest.test_escape_hatch_license_variable.clean_node_before_upgrade=True"

oleiman · 2024-12-03T21:24:10Z

@michael-redpanda - worth noting that datalake_iceberg will still show up in enterprise feature reports (and at the associated API) per

redpanda/src/v/features/enterprise_features.h

Lines 24 to 36 in 03eaa16

    
           enum class license_required_feature { 
        
               audit_logging, 
        
               cloud_storage, 
        
               partition_auto_balancing_continuous, 
        
               core_balancing_continuous, 
        
               gssapi, 
        
               oidc, 
        
               schema_id_validation, 
        
               rbac, 
        
               fips, 
        
               datalake_iceberg, 
        
               leadership_pinning, 
        
           };

I think that's desirable. There's no harm in letting community users know that they're using an enterprise feature. We just don't want to prevent them from turning it on.

oleiman · 2024-12-03T23:28:03Z

CI Failures:

bazel build "normal" test flake
ducktape-debug test_license_enforcement failures that don't reproduce locally, Bad Request errors on patch config.
ducktape-release similar to above

oleiman · 2024-12-03T23:28:17Z

/ci-repeat 1
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":true}

vbotbuildovich · 2024-12-04T01:59:57Z

Retry command for Build#59201

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":true}

oleiman · 2024-12-04T15:36:23Z

/ci-repeat 1
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":true,"clean_node_before_recovery":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":true}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_escape_hatch_license_variable@{"clean_node_before_upgrade":false}
tests/rptest/tests/license_enforcement_test.py::LicenseEnforcementTest.test_license_enforcement@{"clean_node_after_recovery":false,"clean_node_before_recovery":true}

oleiman · 2024-12-04T18:16:12Z

CI Failure:

unrelated bazel flake /src/v/raft/tests:persisted_stm_test

vbotbuildovich · 2024-12-05T13:27:24Z

/backport v24.3.x

config: iceberg_enabled should not be enterprise

83c7c90

For beta version, should not require a license. Signed-off-by: Oren Leiman <[email protected]>

oleiman requested a review from a team as a code owner December 3, 2024 17:59

oleiman requested a review from michael-redpanda December 3, 2024 17:59

oleiman self-assigned this Dec 3, 2024

github-actions bot added the area/redpanda label Dec 3, 2024

oleiman enabled auto-merge December 5, 2024 01:42

michael-redpanda approved these changes Dec 5, 2024

View reviewed changes

oleiman merged commit cbecb9f into redpanda-data:dev Dec 5, 2024
17 checks passed

vbotbuildovich mentioned this pull request Dec 5, 2024

[v24.3.x] config: iceberg_enabled should not be enterprise #24443

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config: iceberg_enabled should not be enterprise #24421

config: iceberg_enabled should not be enterprise #24421

oleiman commented Dec 3, 2024

vbotbuildovich commented Dec 3, 2024

vbotbuildovich commented Dec 3, 2024 •

edited

Loading

vbotbuildovich commented Dec 3, 2024 •

edited

Loading

vbotbuildovich commented Dec 3, 2024 •

edited

Loading

oleiman commented Dec 3, 2024

oleiman commented Dec 3, 2024

oleiman commented Dec 3, 2024

vbotbuildovich commented Dec 4, 2024 •

edited

Loading

oleiman commented Dec 4, 2024

oleiman commented Dec 4, 2024

vbotbuildovich commented Dec 5, 2024

config: iceberg_enabled should not be enterprise #24421

config: iceberg_enabled should not be enterprise #24421

Conversation

oleiman commented Dec 3, 2024

Backports Required

Release Notes

Improvements

vbotbuildovich commented Dec 3, 2024

vbotbuildovich commented Dec 3, 2024 • edited Loading

vbotbuildovich commented Dec 3, 2024 • edited Loading

Retry command for Build#59186

vbotbuildovich commented Dec 3, 2024 • edited Loading

oleiman commented Dec 3, 2024

oleiman commented Dec 3, 2024

oleiman commented Dec 3, 2024

vbotbuildovich commented Dec 4, 2024 • edited Loading

Retry command for Build#59201

oleiman commented Dec 4, 2024

oleiman commented Dec 4, 2024

vbotbuildovich commented Dec 5, 2024

vbotbuildovich commented Dec 3, 2024 •

edited

Loading

vbotbuildovich commented Dec 3, 2024 •

edited

Loading

vbotbuildovich commented Dec 3, 2024 •

edited

Loading

vbotbuildovich commented Dec 4, 2024 •

edited

Loading