Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Update: Implement new fields from scrape #14

Open
dustinblack opened this issue Apr 15, 2023 · 2 comments
Open

UI Update: Implement new fields from scrape #14

dustinblack opened this issue Apr 15, 2023 · 2 comments

Comments

@dustinblack
Copy link
Contributor

Recent changes added new fields for each repo. Need to update the UI to incorporate these fields (and others if more updates come in; see the repositories.json file).

  • contacts (list of dicts)
    • username (string)
    • htmlurl (url string to link username to github user page)
  • maintained (boolean)
@smalleni
Copy link
Contributor

smalleni commented Apr 16, 2023

Thanks for opening this, I was planning on updating the interfaces and table generation. However when trying to develop locally using instructions for running, I can't get the UI to run for any commit from cf62e35

Problem seems to be that https://github.com/redhat-performance/tooling-curator/blob/main/src/App.tsx#L56 does not return a JSOn and instead we get an HTML page.

When trying to go back to 95a96dd npm run start works.

@dustinblack
Copy link
Contributor Author

@smalleni The local UI problem is fixed.

I've also implemented a rudimentary update to the UI to include the new fields, but this still needs work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants