Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReAct agent and a streamlit web app #3

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

hemajv
Copy link
Contributor

@hemajv hemajv commented Oct 24, 2024

In this PR, I've added the code/artifacts for the following:

  • A ReAct tool based agent
  • A streamlit web app

Related issue - #2

(Note: This is based off our existing internal shadowbot project)

Copy link

@suppathak suppathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hema,
Great start. 👍🏼

In addition, I would like to suggest:

  • Adding dependency files (like requirements.txt or pyproject.toml).
  • Including the steps to start both the API service and the Streamlit app.

I was able to start the api service using python react_agent/api.py. However, I encountered issues starting the Streamlit app.

react_agent/common/llm.py Outdated Show resolved Hide resolved
react_agent/tools/math.py Show resolved Hide resolved
sample.env Outdated Show resolved Hide resolved
react_agent/api.py Show resolved Hide resolved
@hemajv
Copy link
Contributor Author

hemajv commented Oct 25, 2024

Hi Hema, Great start. 👍🏼

In addition, I would like to suggest:

  • Adding dependency files (like requirements.txt or pyproject.toml).
  • Including the steps to start both the API service and the Streamlit app.

I was able to start the api service using python react_agent/api.py. However, I encountered issues starting the Streamlit app.

Thanks for the review Surya! I was going to include a dependency file along with a README describing all the steps in a separate PR. Also, what issues were you having with streamlit?

@suppathak
Copy link

what issues were you having with streamlit?

Thanks @hemajv . I got this error while starting the webapp:

streamlit run streamlit/pages/app.py

Error: ModuleNotFoundError: No module named 'util' .

@hemajv
Copy link
Contributor Author

hemajv commented Oct 28, 2024

what issues were you having with streamlit?

Thanks @hemajv . I got this error while starting the webapp:

streamlit run streamlit/pages/app.py

Error: ModuleNotFoundError: No module named 'util' .

@suppathak ah so to run the streamlit app we just need to execute streamlit run webapp/intro.py, I'll mention it in the README

@hemajv
Copy link
Contributor Author

hemajv commented Oct 28, 2024

@suppathak @Shreyanand updated the PR with your suggested changes, ptal!

Copy link

@suppathak suppathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Hema for the update. Added some comment. ptal!

react_agent/README.md Show resolved Hide resolved
react_agent/README.md Outdated Show resolved Hide resolved
react_agent/README.md Outdated Show resolved Hide resolved
streamlit/intro.py Outdated Show resolved Hide resolved
streamlit/pages/app.py Outdated Show resolved Hide resolved
react_agent/README.md Outdated Show resolved Hide resolved
@hemajv
Copy link
Contributor Author

hemajv commented Oct 29, 2024

@suppathak updated the PR with the fixes/modifications, ptal

Copy link

@suppathak suppathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hemajv .👍🏼

@hemajv hemajv merged commit 0041c44 into redhat-et:main Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants