Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ginkgo tests #94

Merged
merged 14 commits into from
Aug 1, 2022
Merged

add ginkgo tests #94

merged 14 commits into from
Aug 1, 2022

Conversation

RobotSail
Copy link
Collaborator

@RobotSail RobotSail commented Jul 15, 2022

This PR aims to introduce Ginkgo as the testing framework to incorporate behavior-driven development.
The goal of adding Ginkgo + Gomega is to define how copilot-ops should behave, and then adjust the code to match the defined behavior.

This PR should close #96 and #73.

Signed-off-by: Oleg [email protected]

Signed-off-by: Oleg <[email protected]>
@RobotSail RobotSail requested a review from guymguym July 15, 2022 17:35
@RobotSail RobotSail requested a review from djach7 July 15, 2022 22:09
@RobotSail RobotSail mentioned this pull request Jul 29, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b2e1212). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage        ?   73.74%           
=======================================
  Files           ?        7           
  Lines           ?      598           
  Branches        ?        0           
=======================================
  Hits            ?      441           
  Misses          ?      135           
  Partials        ?       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e1212...73a7c12. Read the comment docs.

Signed-off-by: Oleg <[email protected]>
Copy link
Contributor

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

pkg/filemap/filemap.go Outdated Show resolved Hide resolved
pkg/cmd/utils.go Outdated Show resolved Hide resolved
Signed-off-by: Oleg <[email protected]>
@guymguym guymguym merged commit 2dd6622 into redhat-et:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override API URL
3 participants