Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reason upper bound for 0.12 #769

Open
anmonteiro opened this issue Sep 5, 2023 · 4 comments
Open

Add Reason upper bound for 0.12 #769

anmonteiro opened this issue Sep 5, 2023 · 4 comments

Comments

@anmonteiro
Copy link
Member

anmonteiro commented Sep 5, 2023

  • needs to have an upper bound < 3.10
  • patch 0.11 in opam with the same upper bound
  • make reactjs-jsx-ppx incompatible with reason-react >= 0.12
  • maybe use post-messages (like merlin)
@jchavarri
Copy link
Collaborator

patch 0.11 in opam with the same upper bound

Second item is being added in ocaml/opam-repository#24367.

@davesnx
Copy link
Member

davesnx commented Oct 25, 2023

  • 1 and 2 are done. reason-react 0.11 and 0.12 have this {>= "3.6.0" & < "3.10.0"}

Would you add a conflict on reactjs-jsx-ppx?

@anmonteiro
Copy link
Member Author

  • 1 and 2 are done. reason-react 0.11 and 0.12 have this {>= "3.6.0" & < "3.10.0"}

Would you add a conflict on reactjs-jsx-ppx?

I think it should be fine, actually. People depend only on reason-react, which brings the ppx along as a a dependency. We don't expect this reactjs-jsx-ppx name to end up in their dependencies.

@davesnx
Copy link
Member

davesnx commented Oct 25, 2023

I we don't mention reactjs-jsx-ppx I don't think people will face the issue also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants