Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations don't appear to dispose resources correctly #4605

Closed
nirinchev opened this issue Apr 10, 2021 · 7 comments
Closed

Migrations don't appear to dispose resources correctly #4605

nirinchev opened this issue Apr 10, 2021 · 7 comments

Comments

@nirinchev
Copy link
Member

I have a migration test that fails during cleanup on Windows because NTFS doesn't allow deleting a file that is still in use. It could very well be something that I'm doing wrong, but as far as I can tell, when a migration callback is invoked something starts using the Realm file and never releases it. For reference, here's the .NET-specific code that deals with migrations and I don't see obvious issues with it.

@fealebenpae
Copy link
Member

Ideally a C++ repro that uses the Object Store APIs is what we'll need to debug this, but at the very least I'll need to see the code of your test, as well as any error information (exception message, stack trace, debugger screenshot, etc.).

@nirinchev
Copy link
Member Author

I'll prepare a simple test case that reproduces this.

@nirinchev
Copy link
Member Author

@fealebenpae I've created a simple repro in this PR: realm/realm-dotnet#2334. I'm guessing you can run the .NET tests, but let me know if you want to look at it together.

@sync-by-unito
Copy link

sync-by-unito bot commented Sep 9, 2021

➤ Jørgen Edelbo commented:

[~yavor.georgiev] since there is a repro test case this should be ready for work. Assigning to you, as you are the only .NET guy around.

@jedelbo
Copy link
Contributor

jedelbo commented Aug 29, 2022

@fealebenpae @nirinchev is this still relevant?

@sync-by-unito
Copy link

sync-by-unito bot commented Jan 16, 2023

➤ bmunkholm commented:

[~[email protected]] [~[email protected]] Still relevant? Will you handle or should someone in the Core team?

@sync-by-unito sync-by-unito bot closed this as completed Jan 16, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 16, 2023

➤ nirinchev commented:

Let's close this - there's nothing to be done on the Core side.

@nirinchev nirinchev closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2023
@sync-by-unito sync-by-unito bot closed this as completed Jan 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants