Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEFORE /AFTER PR #35

Open
esther615kim opened this issue Nov 9, 2021 · 0 comments
Open

BEFORE /AFTER PR #35

esther615kim opened this issue Nov 9, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@esther615kim
Copy link
Contributor

esther615kim commented Nov 9, 2021

BEFORE PR ๐Ÿฅจ

  • Global ์„ธํŒ… ์ถ”๊ฐ€/๋ณ€๊ฒฝ์ด๋‚˜ ์ปค์Šคํ…€ ํ›…์€ ์ฝ”๋ฉ˜ํŠธ๋กœ ์„ค๋ช… ๋‚จ๊ฒจ์ฃผ์„ธ์š”..
  • ํ™•์‹คํ•˜์ง€ ์•Š์€ ๋ถ€๋ถ„์ด๋‚˜ ์˜๋…ผํ•˜๊ณ  ์‹ถ์€ ๋ถ€๋ถ„๋„ ์ฝ”๋ฉ˜ํŠธ๋กœ ๋‚จ๊ฒจ์ฃผ์‹œ๋ฉด ํŒ€ ๋ฏธํŒ… ๋•Œ ์ด์•ผ๊ธฐํ•ด๋ด์š”.

AFTER PR ํ›„์— ํ• ์ผ๐Ÿฅจ

1.๊ฐ€๋Šฅํ•˜๋ฉด ASAP ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ถ€ํƒ๋“œ๋ ค์š”.
์“ฐ์‹ค ๋‚ด์šฉ ์—†์œผ๋ฉด ํ™•์ธํ–ˆ์Œ์ด๋ผ๋„ ๋‚จ๊ฒจ์ฃผ์…”์•ผ PRํ•˜์‹  ๋ถ„์ด ๋จธ์ง€ํ•ฉ๋‹ˆ๋‹ค.
(๋‚ด๊ฐ€ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ์•ˆํ•˜๋ฉด ๋‹ค๋ฅธ ํŒ€์›๋„ ๋‚ด๊บผ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ์•ˆํ•ฉ๋‹ˆ๋‹คใ… )
2. ๋‚ด ์ฝ”๋“œ ๋จธ์ง€ํ•˜๊ธฐ ์ „์—=> ๋จธ์ง€ ์ดํ›„์— ์ด์Šˆ๋‚˜ ์—๋Ÿฌ ์—†๋Š”์ง€ ๋กœ์ปฌ์—์„œ ๋จผ์ € ํ™•์ธํ•˜์‹œ๊ณ 
merge ํ•ด์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@esther615kim esther615kim added the documentation Improvements or additions to documentation label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant