-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sphinx 8 #1582
Comments
High priority, imo! |
This is the error we are getting https://readthedocs.org/projects/spotipy/builds/25216396/
|
Possibly relevant: |
We're hoping to get a 3.0 release out with support for Sphinx 8 soon. There's an open PR here: #1576 -- if you want to try and install from that branch and ensure things look & work well, that would be helpful to us getting it out officially, as testing is the biggest step before a release. |
Tried this out on a project I maintain (wayback), and it seems to work great! Built the docs with dependencies in [project.optional-dependencies]
docs = [
"sphinx ~=8.0.2",
"sphinx_rtd_theme @ git+https://github.com/readthedocs/sphinx_rtd_theme.git@humitos/plan-3.0",
# Probably not relevant, but these were also in use:
"ipython ~=8.16.1",
"numpydoc ~=1.6.0",
"sphinx-copybutton ~=0.5.2",
] Installation resolved correct versions without warnings or errors, Sphinx docs build had no errors, and output looks OK at a quick glance. (Update: forgot to mention this was on Python 3.10, 3.11, 3.12.1, and 3.13.0rc1) |
- update setup.cfg to pyproject.toml - add Windows tests - add Windows-specific torch and numpy constraints - bump Sphinx version to <8 (>= 8 is blocked by - Support Sphinx 8 readthedocs/sphinx_rtd_theme#1582) - use ruff, implement formatting and recommendations - extend .gitignore for PyCharm - update GitHub Actions, make tests run only after successful linting - add support for Python 3.12 - not yet officially suported by PyTorch
We released a new version |
@humitos I really appreciate you remembering me for this! I ended up moving to PyData's Book theme -- that 3rd column was too important to me. However, I do still appreciate this theme like crazy (and use RTD as the host) <3 |
Some major sphinx themes such as for readthedocs and jupyterbooks do not support sphinx 8 yet See readthedocs/sphinx_rtd_theme#1582 Signed-off-by: Pris Nasrat <[email protected]>
…26705) Fixes: #26703 Some major sphinx themes such as for readthedocs and jupyterbooks do not support sphinx 8 yet See readthedocs/sphinx_rtd_theme#1582 - Adds py3-sphinx-7 - Adds py3-sphinx-rtd-theme Signed-off-by: Pris Nasrat <[email protected]> --------- Signed-off-by: Pris Nasrat <[email protected]>
I can confirm that my build worked with 3.0.0rc1 and sphinx 8.0.2. |
This PR bumps the sphinx version. >=8 is blocked by readthedocs/sphinx_rtd_theme#1582 (which looks like it might be released soon).
Remove Sphinx<8 requirement (since readthedocs/sphinx_rtd_theme#1582 was merged) --------- Co-authored-by: Charles Tapley Hoyt <[email protected]>
Sphinx 8 was released on July 29, yet sphinx-rtd-theme requires a Sphinx version less than 8. Please add support for Sphinx 8.
The text was updated successfully, but these errors were encountered: