Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TotalProgression for nearby selection is not different #270

Open
rohitvishwakarma-sf opened this issue Feb 1, 2023 · 0 comments
Open

TotalProgression for nearby selection is not different #270

rohitvishwakarma-sf opened this issue Feb 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rohitvishwakarma-sf
Copy link

Bug Report

What happened?

I want to sort highlights based on their reading order, so sorted them by locator's totalProgression but since totalProgression for nearby selection is same the sorting is not correct.

I added highlights by selecting text near to each other, since the totalProgession of the selection locator is same, I found it difficult to sort the highlights by totalProgression/reading order.

Expected behavior

TotalProgression of different selection locator should not be same.

How to reproduce?

Steps:

  1. Open EPUB
  2. Select text and add highlight
  3. select another text near to the first one without scrolling the page and add highlight

The total progression for both the highlights will output same, which shouldn't be.

Environment

Mac catalyst app
It can be reproduced in any epub but I have attached one for reference.

  • Readium version: 2.4.0

Development environment

echo "macOS: sw_vers -productVersion" -> macOS: 13.1
echo "platform: uname -m" -> platform: arm64
xcodebuild -version -> Xcode 14.2, Build version 14C18

Testing device

  • iOS version: macCatalyst(macOS 13.1 , Ventura)
@mickael-menu mickael-menu added the bug Something isn't working label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants