Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression in Spring Cloud Gateway #1370

Closed
violetagg opened this issue Nov 7, 2020 · 3 comments · Fixed by #1371
Closed

Performance regression in Spring Cloud Gateway #1370

violetagg opened this issue Nov 7, 2020 · 3 comments · Fixed by #1371
Assignees
@violetagg
Labels
type/bug A general bug warn/regression A regression from a previous release
Milestone
0.9.14.RELEASE

Comments

@violetagg
Copy link
Member

Related to spring-cloud/spring-cloud-gateway#1956
@violetagg violetagg added type/bug A general bug warn/regression A regression from a previous release labels Nov 7, 2020
@violetagg violetagg added this to the 0.9.14.RELEASE milestone Nov 7, 2020
@violetagg violetagg self-assigned this Nov 7, 2020
@johndudo
Copy link

johndudo commented Nov 7, 2020

when are you going to release 0.9.14.RELEASE, before 0.9.14.RELEASE come out, use 0.9.7 instead? Is 0.9.7 stable?

violetagg added a commit that referenced this issue Nov 7, 2020
@violetagg
Guarantee there is no race between subscribe and other operations inv…
1a4651d 
…oked in an event loop

This is a quick fix for the regression introduced with #1185

Related to #1370 and #1350
@violetagg violetagg mentioned this issue Nov 7, 2020
Merged
@violetagg
Copy link
Member Author

The issue is a regression caused by #1185 that is released with 0.9.10.RELEASE

@johndudo For the moment 0.9.14.RELEASE is scheduled for 07.12
The regression is introduced in 0.9.10.RELEASE so you can either use 0.9.7.RELEASE or 0.9.9.RELEASE

@violetagg violetagg linked a pull request Nov 7, 2020 that will close this issue
Guarantee there is no race between subscribe and other operations invoked in an event loop #1371
Merged
@violetagg violetagg mentioned this issue Nov 7, 2020
Closed
@violetagg
Copy link
Member Author

0.9.14.RELEASE is available with the fix from the PR #1371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/bug A general bug warn/regression A regression from a previous release
Projects
None yet
Milestone
0.9.14.RELEASE
2 participants
@violetagg @johndudo