From 1e349c07c855a3b6de1455908ad143bca9e4167a Mon Sep 17 00:00:00 2001 From: Emmanuel Pelletier Date: Thu, 26 Jul 2018 18:12:58 +0200 Subject: [PATCH] [fixed] remove aria-modal attr to prevent browser bugs There were a couple problems with the aria-modal attribute: - it was not set on the correct dom element (in theory, it should be set on the element having the dialog role, as stated in #654) - it is buggy in Safari. The easy way to fix the problem is to remove the attribute (again, as suggested in #654). While it's cool on paper, the attribute is currently not necessary, since the `aria-hidden="true"` is set correctly on the app element. --- src/components/ModalPortal.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/ModalPortal.js b/src/components/ModalPortal.js index fca33769..e50d9911 100644 --- a/src/components/ModalPortal.js +++ b/src/components/ModalPortal.js @@ -334,7 +334,6 @@ export default class ModalPortal extends Component { style={{ ...overlayStyles, ...this.props.style.overlay }} onClick={this.handleOverlayOnClick} onMouseDown={this.handleOverlayOnMouseDown} - aria-modal="true" >