Introduce theming of Badge color variants
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
force-pushed
the
feature/badge-theming-using-collections
branch
2 times, most recently
from
1351bc8 to
c272c09
Compare
bedrich-schindler
approved these changes
Sep 3, 2024
adamkudrna
force-pushed
the
bc/badge-priority-class
branch
from
2c491b8 to
c3e3222
Compare
`Badge` color variants are now generated using color collections. Other components to be styled the same way already support theming, so `Badge` needs to support theming too. New theming options: `--rui-Badge--<PRIORITY>--<COLOR>__<PROPERTY>` See `theme.scss` for all available options.
adamkudrna
force-pushed
the
feature/badge-theming-using-collections
branch
from
c272c09 to
34b7052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Badgecolor variants are now generated using color collections.Other components to be styled the same way already support theming,
so
Badgeneeds to support theming too.New theming options:
--rui-Badge--<PRIORITY>--<COLOR>__<PROPERTY>See
theme.scssfor all available options.