From 59b46a483ea67adc1747f8852165e68fa476b6df Mon Sep 17 00:00:00 2001 From: Caleb Hoff Date: Sat, 22 Oct 2022 13:43:37 -0500 Subject: [PATCH] =?UTF-8?q?chore:=20=F0=9F=94=A7=20maintenance(multiple)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * upd8 i18next, stylelint, types, & rmv router types * upgrade media query tool to allow minification * prefer const enum * vscode lint format on save * improve testing docs * refactor(react): ♻️ create root like in CRA template * style(changelog): 🎨 consistent changelog headers * docs(editors): 📚️ remove chrome debugger mention * docs(yarn): 📚️ add yarn 3 documentation & gitignore * docs(yarn): 📚️ add yarn install --- .all-contributorsrc | 16 +- .gitignore | 10 + .vscode/settings.json | 8 +- CHANGELOG.md | 10 +- README.md | 3 +- docs/SUMMARY.md | 1 + docs/building-blocks/css.md | 8 +- docs/building-blocks/testing.md | 4 +- docs/tools/editors.md | 9 +- docs/tools/package-managers.md | 59 +++ internals/generators/component/index.ts | 2 +- internals/generators/slice/index.ts | 2 +- internals/startingTemplate/src/index.tsx | 8 +- .../src/styles/__tests__/media.test.ts | 4 +- .../startingTemplate/src/styles/media.ts | 42 +- package.json | 37 +- .../Features/GithubRepoForm/slice/types.ts | 2 +- src/index.tsx | 8 +- src/styles/StyleConstants.ts | 2 +- src/styles/__tests__/media.test.ts | 4 +- src/styles/media.ts | 42 +- template.json | 33 +- yarn.lock | 393 ++++++++---------- 23 files changed, 358 insertions(+), 349 deletions(-) create mode 100644 docs/tools/package-managers.md diff --git a/.all-contributorsrc b/.all-contributorsrc index 5ec4119e..14509efe 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -45,7 +45,7 @@ { "login": "lourensdev", "name": "Lourens de Villiers", - "avatar_url": "https://avatars.githubusercontent.com/u/5746141?v=4", + "avatar_url": "https://avatars.githubusercontent.com/u/5746141", "profile": "https://github.com/lourensdev", "contributions": [ "doc" @@ -54,13 +54,25 @@ { "login": "rejochandran", "name": "Rejo Chandran", - "avatar_url": "https://avatars.githubusercontent.com/u/4696985?v=4", + "avatar_url": "https://avatars.githubusercontent.com/u/4696985", "profile": "https://github.com/rejochandran", "contributions": [ "code", "doc", "test" ] + }, + { + "login": "qeleb", + "name": "Caleb Hoff", + "avatar_url": "https://avatars.githubusercontent.com/u/15345696", + "profile": "https://github.com/qeleb", + "contributions": [ + "code", + "doc", + "ideas", + "test" + ] } ], "contributorsPerLine": 8, diff --git a/.gitignore b/.gitignore index 5452f77e..86111446 100644 --- a/.gitignore +++ b/.gitignore @@ -9,9 +9,19 @@ stats.json # misc .DS_Store npm-debug.log* + +# yarn yarn-debug.log* yarn-error.log* +.pnp.* +.yarn/* +!.yarn/patches +!.yarn/plugins +!.yarn/releases +!.yarn/sdks +!.yarn/versions +# env .env.development.local .env.test.local .env.production.local diff --git a/.vscode/settings.json b/.vscode/settings.json index 57491897..107d0e65 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -15,5 +15,11 @@ }, "[html]": { "editor.defaultFormatter": "esbenp.prettier-vscode" - } + }, + "editor.codeActionsOnSave": { + "source.fixAll": true, + "source.fixAll.eslint": true + }, + "editor.formatOnSave": true, + "javascript.format.enable": false } diff --git a/CHANGELOG.md b/CHANGELOG.md index 898e12db..7080724e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,13 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. -### [1.2.5](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.2.4...v1.2.5) (2022-06-20) +## [1.2.5](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.2.4...v1.2.5) (2022-06-20) ### Internals - 🔧 bump react to 18.1 ([#170](https://github.com/react-boilerplate/react-boilerplate-cra-template/issues/170)) ([7ef3155](https://github.com/react-boilerplate/react-boilerplate-cra-template/commit/7ef31555a29c273ffd02b55f30f913218d13eb1f)) -### [1.2.4](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.2.3...v1.2.4) (2022-04-12) +## [1.2.4](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.2.3...v1.2.4) (2022-04-12) ### Bug Fixes @@ -96,7 +96,7 @@ All notable changes to this project will be documented in this file. See [standa - 🔧 switched to yarn ([#89](https://github.com/react-boilerplate/react-boilerplate-cra-template/issues/89)) ([2a90e24](https://github.com/react-boilerplate/react-boilerplate-cra-template/commit/2a90e24b8eaf8adcfb6008f20a2fc4a8f83bfa33)) -### [1.0.2](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.0.1...v1.0.2) (2020-10-27) +## [1.0.2](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.0.1...v1.0.2) (2020-10-27) Quick patch for cra v4 bug. No changes @@ -104,7 +104,7 @@ Quick patch for cra v4 bug. No changes - CRA v4 bug fix ([#79](https://github.com/react-boilerplate/react-boilerplate-cra-template/issues/79)) ([2cae593](https://github.com/react-boilerplate/react-boilerplate-cra-template/commit/2cae593fbd53ee1e6e4a7f31cf50781c1b1ab6b9)) -### [1.0.1](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.0.0...v1.0.1) (2020-07-03) +## [1.0.1](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v1.0.0...v1.0.1) (2020-07-03) ### Bug Fixes @@ -168,7 +168,7 @@ Quick patch for cra v4 bug. No changes -### [0.1.3](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v0.1.2...v0.1.3) (2020-05-05) +## [0.1.3](https://github.com/react-boilerplate/react-boilerplate-cra-template/compare/v0.1.2...v0.1.3) (2020-05-05) ### Bug Fixes diff --git a/README.md b/README.md index 50c45b63..b3360797 100644 --- a/README.md +++ b/README.md @@ -135,7 +135,8 @@ But wait... there's more!
Recep Tiryaki
💻 🤔 🎨
David Bingham
📖
Lourens de Villiers
📖 -
Rejo Chandran
💻 📖 ⚠️ +
Rejo Chandran
💻 📖 ⚠️ +
Caleb Hoff
💻 📖 🤔 ⚠️ diff --git a/docs/SUMMARY.md b/docs/SUMMARY.md index 2a851768..9625a305 100644 --- a/docs/SUMMARY.md +++ b/docs/SUMMARY.md @@ -7,6 +7,7 @@ - [CLI & Scaffolding](tools/commands.md) - [Editor Configuration](tools/editors.md) +- [Package Managers](tools/package-managers.md) ## Building Blocks diff --git a/docs/building-blocks/css.md b/docs/building-blocks/css.md index a33cb608..8eb495c1 100644 --- a/docs/building-blocks/css.md +++ b/docs/building-blocks/css.md @@ -65,9 +65,9 @@ import { media } from 'styles/media'; const SomeDiv = styled.div` display: flex; - .... - ${media.medium` - display: block - `}; + .... ${media.medium} { + display: block; + } `; +``; ``` diff --git a/docs/building-blocks/testing.md b/docs/building-blocks/testing.md index 4ea3d01a..c2f71c2a 100644 --- a/docs/building-blocks/testing.md +++ b/docs/building-blocks/testing.md @@ -51,7 +51,7 @@ function HomePage() { _Note: This is a [state**ful** (or "smart") component](../understanding-react-boilerplate.md#src-app)_ -When rendered normally with the standard `ReactDOMClient.createRoot` function, this will be the HTML output +When rendered normally with the standard `ReactDOMClient.createRoot().render()` function, this will be the HTML output (_Comments added in parallel to compare structures in HTML from JSX source_): ```html @@ -177,3 +177,5 @@ describe('