Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warnings in management #1070

Open
jochenklar opened this issue Jul 20, 2024 · 0 comments
Open

Improve warnings in management #1070

jochenklar opened this issue Jul 20, 2024 · 0 comments
Milestone

Comments

@jochenklar
Copy link
Member

So, after @sa-wetter raised the issue in the meeting, I had a look at the warnings in the management interface and they are not working as intended. The API shows a warning = true if one of the language field is not set properly. ElementWarningSerializerMixin does that (https://github.com/rdmorganiser/rdmo/blob/dev-2.2.0/rdmo/core/serializers.py#L187-L188). In addition a warning should be shown if an attribute is missing from a question or from a page with is_collection = True.

In principle, all of that could be done in the front-end, but one could argue that the creation of the warning in the backend is also useful, since it provides this information to all possible API clients.

I think there should be a warning message in a similar form as the validation messages are done.

@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant