You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, after @sa-wetter raised the issue in the meeting, I had a look at the warnings in the management interface and they are not working as intended. The API shows a warning = true if one of the language field is not set properly. ElementWarningSerializerMixin does that (https://github.com/rdmorganiser/rdmo/blob/dev-2.2.0/rdmo/core/serializers.py#L187-L188). In addition a warning should be shown if an attribute is missing from a question or from a page with is_collection = True.
In principle, all of that could be done in the front-end, but one could argue that the creation of the warning in the backend is also useful, since it provides this information to all possible API clients.
I think there should be a warning message in a similar form as the validation messages are done.
The text was updated successfully, but these errors were encountered:
So, after @sa-wetter raised the issue in the meeting, I had a look at the warnings in the management interface and they are not working as intended. The API shows a
warning = true
if one of the language field is not set properly.ElementWarningSerializerMixin
does that (https://github.com/rdmorganiser/rdmo/blob/dev-2.2.0/rdmo/core/serializers.py#L187-L188). In addition a warning should be shown if an attribute is missing from a question or from a page withis_collection = True
.In principle, all of that could be done in the front-end, but one could argue that the creation of the warning in the backend is also useful, since it provides this information to all possible API clients.
I think there should be a warning message in a similar form as the validation messages are done.
The text was updated successfully, but these errors were encountered: