Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated web-browser interfaces #4480

Open
piotr-marcinkowski-red opened this issue Oct 4, 2023 · 0 comments
Open

Duplicated web-browser interfaces #4480

piotr-marcinkowski-red opened this issue Oct 4, 2023 · 0 comments

Comments

@piotr-marcinkowski-red
Copy link

piotr-marcinkowski-red commented Oct 4, 2023

This issue is to assess if potential rework is necessary around multiple web-browser interfaces with similar functionality.

IBrowserResources interface with UserScripts / UserStyleSheets methods was included into ThunderInterfaces: rdkcentral/ThunderInterfaces@cccdfaa

A year later a similar interface was also added to IBrowser.h: IBrowserScripting with RunJavaScript / AddUserScript / RemoveAllUserScripts methods:
rdkcentral/ThunderInterfaces@37e1fcf

The two interfaces overlaps in terms of functionality of executing user scripts but they are not exactly the same:

  • IBrowserResources::UserScripts executes scripts pointed by URI (file://)
  • IBrowserScripting::AddUserScript executes script code given as parameter

Please assess if the described functionalities scattered across multiple interfaces can be put in one place.
If I recall correctly any changes in Thunder interfaces can be introduced only when major version of these interfaces gets increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant