You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is to assess if potential rework is necessary around multiple web-browser interfaces with similar functionality.
IBrowserResources interface with UserScripts / UserStyleSheets methods was included into ThunderInterfaces: rdkcentral/ThunderInterfaces@cccdfaa
A year later a similar interface was also added to IBrowser.h: IBrowserScripting with RunJavaScript / AddUserScript / RemoveAllUserScripts methods: rdkcentral/ThunderInterfaces@37e1fcf
The two interfaces overlaps in terms of functionality of executing user scripts but they are not exactly the same:
IBrowserResources::UserScripts executes scripts pointed by URI (file://)
IBrowserScripting::AddUserScript executes script code given as parameter
Please assess if the described functionalities scattered across multiple interfaces can be put in one place.
If I recall correctly any changes in Thunder interfaces can be introduced only when major version of these interfaces gets increased.
The text was updated successfully, but these errors were encountered:
This issue is to assess if potential rework is necessary around multiple web-browser interfaces with similar functionality.
IBrowserResources interface with UserScripts / UserStyleSheets methods was included into ThunderInterfaces: rdkcentral/ThunderInterfaces@cccdfaa
A year later a similar interface was also added to IBrowser.h: IBrowserScripting with RunJavaScript / AddUserScript / RemoveAllUserScripts methods:
rdkcentral/ThunderInterfaces@37e1fcf
The two interfaces overlaps in terms of functionality of executing user scripts but they are not exactly the same:
Please assess if the described functionalities scattered across multiple interfaces can be put in one place.
If I recall correctly any changes in Thunder interfaces can be introduced only when major version of these interfaces gets increased.
The text was updated successfully, but these errors were encountered: