gh #277 dsVideoPort L3 for an API dsSetAllmEnabled #279

KarthikeyanR470 · 2024-12-18T17:08:36Z

Added L3 test case for dsSetAllmEnabled

ishthiyaqahmed · 2024-12-19T08:49:11Z

host/tests/dsClasses/dsVideoPort.py

+        ]
+
+        # Convert input arguments to strings and update the prompts
+        promptWithAnswers[0]["input"] = str(video_port)


could you please directly assign strings to input like below.
"input": str(video_port)
"input": str(port_index)
"input": str(mode)

Actually, all other methods follow a similar approach of assigning strings to the input. Therefore, I maintained the same format in this API for consistency.

ishthiyaqahmed · 2024-12-19T09:31:42Z

host/tests/L3_TestCases/dsVideoPort/dsVideoPort_test10_VerifyALLM_Mode.py

+        # Loop through supported video ports and verify ALLM Mode
+        for port, index in self.testdsVideoPort.getSupportedPorts():
+            self.testEnablePort(port, index)
+            # Set the ALLM Mode as Enable


could you please add stepstart form here.

Actually, all other methods test cases follow a similar approach of adding stepstart . Therefore, I maintained the same format in this test_case for consistency.

ishthiyaqahmed · 2024-12-19T09:33:14Z

host/tests/L3_TestCases/dsVideoPort/dsVideoPort_test10_VerifyALLM_Mode.py

+        for port, index in self.testdsVideoPort.getSupportedPorts():
+            self.testEnablePort(port, index)
+            # Set the ALLM Mode as Enable
+            self.testdsVideoPort.setAllmMode(port, index, 'Enable')


Here we are setting the ALLM mode , why cant we verify through the getAllmMode.

Actually, the verification is performed using an AV analyzer to directly observe the ALLM status and ensure compliance with HDMI specifications. Therefore, the getAllmMode method is not utilized in this context.

ishthiyaqahmed · 2024-12-19T09:36:03Z

src/test_l3_dsVideoPort.c

+
+    UT_LOG_INFO("Calling dsGetAllmEnabled(IN:Handle:[0x%0X],OUT:ALLM_Status:[]) ", gHandle);
+    status = dsGetAllmEnabled(gHandle, &AllmMode);
+    UT_LOG_INFO("Result dsGetAllmEnabled(IN:Handle:[0x%0X],OUT:ALLM_Status:[%s]) ,dsError_t=[%s]",gHandle, AllmMode,\


could you please make the code aligned here.

ishthiyaqahmed · 2024-12-19T09:36:58Z

src/test_l3_dsVideoPort.c

+
+    UT_LOG_INFO("Calling dsSetAllmEnabled(IN:Handle:[0x%0X],IN:ALLM_Status:[]) ", gHandle);
+    status = dsSetAllmEnabled(gHandle, choice);
+    UT_LOG_INFO("Result dsSetAllmEnabled(IN:Handle:[0x%0X],IN:ALLM_Status:[%s]) ,dsError_t=[%s]",gHandle, UT_Control_GetMapString(boolMappingTable, choice),\


please make the code aligned here.

ishthiyaqahmed · 2024-12-19T09:37:55Z

src/test_l3_dsVideoPort.c

+void dsVideoPort_GetAllmEnabled()
+{
+    dsError_t status   = dsERR_NONE;
+    bool AllmMode;


AllmMode ,assign with the default value.

updated with default value.

ishthiyaqahmed · 2024-12-19T09:39:57Z

host/tests/L3_TestCases/dsVideoPort/dsVideoPort_test10_VerifyALLM_Mode.py

+            bool: Result of the ALLM mode verification.
+        """
+        if manual == True:
+            #hdcpVersion = self.testdsVideoPort.getHDCPVersion()


can you please remove the commented line if it is not required.

Removed the commented line.

hari22yuva

please check review comments

hari22yuva · 2024-12-20T10:32:28Z

docs/pages/dsVideoPort/ds-video-port_L3_Low-Level_TestSpecification.md

@@ -56,6 +56,7 @@ Below are top test use-case for the video port.
 |7|Resets the video output to `SDR` for Source |Play the `HDR` stream and verify the video content formats|`dsResetOutputToSDR()`|`Y`|`NA`|1|
 |8|Select preferred color depth for Source|Select the Color depth from Supported list & verify|`dsSetPreferredColorDepth()`|`Y`|`NA`|`NA`|
 |9|sets the background color for Source |Select the background color form supported list & verify|`dsSetBackgroundColor()`|`Y`|`NA`|`NA`|
+|10|Enables/Disables ALLM mode for HDMI output video port |Select the ALLM mode for HDMI output video port and verify|`dsSetAllmEnabled()`|`Y`|`NA`|`NA`|


if not add in ds-video-port_High-Level_TestSpec.md please add ALLM mode test case

Updated ALLm mode test case in ds-video-port_High-Level_TestSpec.md

hari22yuva · 2024-12-20T10:37:45Z

src/test_l3_dsVideoPort.c

+    if(choice < 0 || choice > 1) 
+    {
+       UT_LOG_ERROR("\nInvalid ALLM mode selected\n");
+       goto exit;


don't use goto

Removed the goto and updated the code.

hari22yuva · 2024-12-20T10:38:24Z

src/test_l3_dsVideoPort.c

+    }
+
+    UT_LOG_INFO("Calling dsSetAllmEnabled(IN:Handle:[0x%0X],IN:ALLM_Status:[]) ", gHandle);
+    status = dsSetAllmEnabled(gHandle, choice);


add
DS_ASSERT(status == dsERR_NONE);

added DS_ASSERT(status == dsERR_NONE);

hari22yuva · 2024-12-20T10:46:02Z

src/test_l3_dsVideoPort.c

+
+    UT_LOG_INFO("Calling dsGetAllmEnabled(IN:Handle:[0x%0X],OUT:ALLM_Status:[]) ", gHandle);
+    status = dsGetAllmEnabled(gHandle, &AllmMode);
+    UT_LOG_INFO("Result dsGetAllmEnabled(IN:Handle:[0x%0X],OUT:ALLM_Status:[%s]) ,dsError_t=[%s]",gHandle, AllmMode,\


allmode is a bool so add
UT_Control_GetMapString(boolMappingTable, AllmMode)

Added UT_Control_GetMapString(boolMappingTable, AllmMode)

hari22yuva · 2024-12-20T10:46:43Z

src/test_l3_dsVideoPort.c

+    dsVideoPort_getHandle();
+
+    UT_LOG_INFO("Calling dsGetAllmEnabled(IN:Handle:[0x%0X],OUT:ALLM_Status:[]) ", gHandle);
+    status = dsGetAllmEnabled(gHandle, &AllmMode);


add
DS_ASSERT(status == dsERR_NONE);

added DS_ASSERT(status == dsERR_NONE);

hari22yuva · 2024-12-20T10:50:31Z

host/tests/dsClasses/dsVideoPort.py

+
+        result = self.utMenu.select(self.testSuite, "Set AllmMode", promptWithAnswers)
+
+


add dsGetAllmEnabled() in the class ?

Added dsGetAllmEnabled() in the class

hari22yuva · 2024-12-20T10:56:46Z

host/tests/L3_TestCases/dsVideoPort/dsVideoPort_test10_VerifyALLM_Mode.py

+        """
+        if manual == True:
+            #hdcpVersion = self.testdsVideoPort.getHDCPVersion()
+            return self.testUserResponse.getUserYN(f'Is ALLM Mode (Enable/Disable) is displayed on Analyzer (Y/N): ')


Need to specify the is enabled or disabled not both
like is ALLM Mode Enabled ?

updated for respective modes seperately.

hari22yuva · 2024-12-20T10:58:22Z

host/tests/L3_TestCases/dsVideoPort/dsVideoPort_test10_VerifyALLM_Mode.py

+#!/usr/bin/env python3
+#** *****************************************************************************
+# *
+# * If not stated otherwise in this file or this component's LICENSE file the


please update this test case to run all source python

Updated the file dsVideoPort_RunAll_L3_SinkTest.py

gh #277 Added a L3 for an API dsSetAllmEnabled and dsGetAllmEnabled

0c01264

KarthikeyanR470 linked an issue Dec 19, 2024 that may be closed by this pull request

dsVideoPort: Handle L3 for an API dsSetAllmEnabled #277

Open

KarthikeyanR470 changed the title ~~gh #277 Added a L3 for an API dsSetAllmEnabled~~ gh #277 dsVideoPort L3 for an API dsSetAllmEnabled Dec 19, 2024

gh #277 updated L3_low_level_specfication and test_procedure documents

e494d62

srinivasgtl requested review from hari22yuva and ishthiyaqahmed December 19, 2024 08:07

srinivasgtl assigned KarthikeyanR470 Dec 19, 2024

srinivasgtl added enhancement New feature or request L3 Work Element labels Dec 19, 2024

srinivasgtl added this to the VTS L1/L2/L3 - Phase 4 updates and bug fixes. milestone Dec 19, 2024

ishthiyaqahmed reviewed Dec 19, 2024

View reviewed changes

hari22yuva reviewed Dec 20, 2024

View reviewed changes

KarthikeyanR470 added 3 commits December 20, 2024 15:22

gh #277 Addressed review comments

d9a3cf6

gh #277 updated test_l3_dsVideoPort.c

69917e2

gh #277 updated high-spec doc

0634e67

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh #277 dsVideoPort L3 for an API dsSetAllmEnabled #279

gh #277 dsVideoPort L3 for an API dsSetAllmEnabled #279

KarthikeyanR470 commented Dec 18, 2024 •

edited

Loading

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

ishthiyaqahmed Dec 19, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva left a comment

hari22yuva Dec 20, 2024 •

edited

Loading

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024

hari22yuva Dec 20, 2024

KarthikeyanR470 Dec 20, 2024


		result = self.utMenu.select(self.testSuite, "Set AllmMode", promptWithAnswers)

gh #277 dsVideoPort L3 for an API dsSetAllmEnabled #279

Are you sure you want to change the base?

gh #277 dsVideoPort L3 for an API dsSetAllmEnabled #279

Conversation

KarthikeyanR470 commented Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hari22yuva left a comment

Choose a reason for hiding this comment

hari22yuva Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KarthikeyanR470 commented Dec 18, 2024 •

edited

Loading

hari22yuva Dec 20, 2024 •

edited

Loading