Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsAudio: L1 bug bitwise operation done with wrong value for dsSetVolumeLeveller #272

Open
thanushreevani opened this issue Dec 12, 2024 · 0 comments · Fixed by #273
Open

dsAudio: L1 bug bitwise operation done with wrong value for dsSetVolumeLeveller #272

thanushreevani opened this issue Dec 12, 2024 · 0 comments · Fixed by #273
Assignees
@thanushreevani
Labels
bug Something isn't working L1 related issues
Milestone
VTS L1/L2/L3 - Ph...

Comments

@thanushreevani
Copy link
Contributor

There’s a discrepancy in the bitwise operation for dsSetVolumeLeveller The bit set for dsMS12SUPPORT_VolumeLeveller is 0x08, but the test case is using 0x04. as mentioned below:

if(gDSAudioPortConfiguration[i].ms12_capabilites & 0x04)

This discrepancy only observed in dsSetVolumeleveller case , in dsGetVolumeLeveller the gDSAudioPortConfiguration[i].ms12_capabilites bitwise operation is performed against 0x08.
thanushreevani added a commit that referenced this issue Dec 12, 2024
@thanushreevani
gh #272 change the correct value for bitwise operation
271adfe
@thanushreevani thanushreevani linked a pull request Dec 12, 2024 that will close this issue
gh #272 change the correct value for bitwise operation #273
Merged
@srinivasgtl srinivasgtl added bug Something isn't working L1 related issues labels Dec 16, 2024
@srinivasgtl srinivasgtl moved this to Approved For Merge in HAL Interface - Upgrades Dec 16, 2024
hari22yuva added a commit that referenced this issue Dec 17, 2024
@hari22yuva
Merge pull request #273 from rdkcentral/feature/issue272_dsAudio_L1_b…
6ee4eae 
…ug_dsSetVolumeLeveller

gh #272 change the correct value for bitwise operation
@srinivasgtl srinivasgtl moved this from Approved For Merge to Closed in HAL Interface - Upgrades Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanushreevani thanushreevani

Labels
bug Something isn't working L1 related issues
Projects
HAL Interface - Upgrades
Status: Closed
Milestone
VTS L1/L2/L3 - Phase 4 updates and bu...
Development

Successfully merging a pull request may close this issue.

gh #272 change the correct value for bitwise operation rdkcentral/rdk-halif-test-device_settings
2 participants
@srinivasgtl @thanushreevani