Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal_test binary not created when TARGET=linux is passed to ./build.sh or to make #227

Open
kanjoe24 opened this issue Oct 16, 2024 · 0 comments · Fixed by #278
Open

hal_test binary not created when TARGET=linux is passed to ./build.sh or to make #227

kanjoe24 opened this issue Oct 16, 2024 · 0 comments · Fixed by #278
Assignees
@hari22yuva
Labels
bug Something isn't working
Milestone
VTS L1/L2/L3 - Ph...

Comments

@kanjoe24
Copy link

Observed that hal_test binary is not created while building ut when the command is ./build.sh TARGET=linux or make TARGET=linux. However same works fine w/o TARGET=linux.

The issue is in makefile:(https://github.com/rdkcentral/rdk-halif-test-device_settings/blob/main/Makefile#L32)

ifeq ($(TARGET),)
$(info TARGET NOT SET )
$(info TARGET FORCED TO Linux)
TARGET=linux
SRC_DIRS += $(ROOT_DIR)/skeletons/src
endif

This part of the code runs only when TARGET is empty and sets the SRC_DIRS. However when TARGET=linux, SRC_DIRS is not set and hence the error.
build.sh TARGET=linux.pdf
@srinivasgtl srinivasgtl added the bug Something isn't working label Dec 16, 2024
hari22yuva added a commit that referenced this issue Dec 17, 2024
@hari22yuva
gh #227 updated Make file with target=linux
b63f5d4
@srinivasgtl srinivasgtl linked a pull request Dec 17, 2024 that will close this issue
gh #227 updated Make file with target=linux #278
Merged
@srinivasgtl srinivasgtl moved this from Todo to Approved For Merge in HAL Interface - Upgrades Dec 17, 2024
hari22yuva added a commit that referenced this issue Dec 17, 2024
@hari22yuva
gh #227 updated Make file with target=linux
1183a22
hari22yuva added a commit that referenced this issue Dec 18, 2024
@hari22yuva
Merge pull request #278 from rdkcentral/feature/gh227_hal_test_binary…
b735ced 
…_not_created_target=linux

gh #227 updated Make file with target=linux
@srinivasgtl srinivasgtl moved this from Approved For Merge to Closed in HAL Interface - Upgrades Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari22yuva hari22yuva

Labels
bug Something isn't working
Projects
HAL Interface - Upgrades
Status: Closed
Milestone
VTS L1/L2/L3 - Phase 4 updates and bu...
Development

Successfully merging a pull request may close this issue.

gh #227 updated Make file with target=linux rdkcentral/rdk-halif-test-device_settings
3 participants
@hari22yuva @srinivasgtl @kanjoe24