Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: RDKE-41 Enhance component versioning and standard build support #34

Closed
wants to merge 1 commit into from
Closed

PR: RDKE-41 Enhance component versioning and standard build support #34

wants to merge 1 commit into from

Conversation

arun-madhavan-013
Copy link

Enhance component versioning and standard build support by decoupling the install directory restructuring.

Problem:

How it helps:
Newly introduced pkg-config file will have the header component version and standard build flow can detect it.
when pkg-config is having 2.0.0

VM2[26/Apr|17:46:31]git# pkg-config --cflags 'halif-devicesettings >= 2.0.0' --print-errors
Requested 'halif-devicesettings >= 2.0.0' but version of DSHALHeaders is 1.0.8
VM2[26/Apr|17:46:58]git#

when pkg-config is having 1.0.8

VM2[26/Apr|17:46:59]git# pkg-config --cflags 'halif-devicesettings >= 1.0.8' --print-errors
-I/home/amadha013/community/build-raspberrypi4-64-rdk-mc/tmp/work/raspberrypi4-64-rdk-mc-vendor-rdkmllib32-linux-gnueabi/lib32-devicesettings-hal-raspberrypi4/1.0.0-r0/lib32-recipe-sysroot/usr/include/rdk/halif/ds-hal
VM2[26/Apr|17:47:06]git#

When vendor or middleware component builds; it can do a standard find pkg-config step and get the respective header installation path provided by halif-devicesettings.pc even if it is non-standard location. This helps to decouple the compile flag modification required to match Problem statement 2 similar changes.
One-time change required in meta-rdk-halif-headers

Install the respective pkg-config file from meta-rdk-halif-headers recipe.

diff --git a/recipes-rdk-halif-headers/devicesettings/devicesettings-hal-headers.bb b/recipes-rdk-halif-headers/devicesettings/devicesettings-hal-headers.bb
index 0826887..d433e60 100644
--- a/recipes-rdk-halif-headers/devicesettings/devicesettings-hal-headers.bb
+++ b/recipes-rdk-halif-headers/devicesettings/devicesettings-hal-headers.bb
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e"

 SRC_URI = "${CMF_GITHUB_ROOT}/rdk-halif-device_settings;${CMF_GITHUB_SRC_URI_SUFFIX}"

-inherit allarch
+inherit allarch pkgconfig

 S = "${WORKDIR}/git"

@@ -35,6 +35,9 @@ ALLOW_EMPTY_${PN} = "1"
 do_install() {
     install -d ${D}${includedir}/rdk/halif/ds-hal
     install -m 0644 ${S}/include/*.h ${D}${includedir}/rdk/halif/ds-hal
+
+    install -d ${D}${libdir}/pkgconfig
+    install -m 0644 ${S}/../halif-devicesettings.pc ${D}${libdir}/pkgconfig/
 }

 do_install[vardepsexclude] += "S"

@arun-madhavan-013
RDKE-41 Enhance component versioning and standard build support by de…
5be5e16 
…coupling the install directory restructuring.
Ulrond
Ulrond suggested changes May 3, 2024
View reviewed changes
Copy link

@Ulrond Ulrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cannot be a fork, contributing to this code is via branching the codebase only, and raising a ticket in the issue list, and using that as the branch name.

Generating a pull request to develop from the feature/ghxx_synopsis code change.

See -> https://github.com/rdkcentral/rdk-halif-device_settings/blob/main/CONTRIBUTING.md

@Ulrond Ulrond added the bug Something isn't working label May 3, 2024
@arun-madhavan-013
Copy link
Author

Hi @Ulrond ,
I'm facing error when I do a direct push as below:

VM2[03/May|12:15:39]rdk-halif-device_settings$ git push
fatal: The current branch 35_build_support_enhancement has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin 35_build_support_enhancement

VM2[03/May|12:15:42]rdk-halif-device_settings$ git push --set-upstream origin 35_build_support_enhancement
remote: Permission to rdkcentral/rdk-halif-device_settings.git denied to arun-madhavan-013.
fatal: unable to access 'https://github.com/rdkcentral/rdk-halif-device_settings.git/': The requested URL returned error: 403
VM2[03/May|12:15:48]rdk-halif-device_settings$
VM2[03/May|12:16:05]rdk-halif-device_settings$ git remote -v
origin  https://github.com/rdkcentral/rdk-halif-device_settings.git (fetch)
origin  https://github.com/rdkcentral/rdk-halif-device_settings.git (push)
VM2[03/May|12:16:11]rdk-halif-device_settings$

Without forking and adding a commit; i'm not able to create a PR.
Could you please advise on this ?

@hari22yuva
Copy link
Contributor

@arun-madhavan-013 ,
Are you able to create branch in this repo?

@Ulrond Ulrond linked an issue May 16, 2024 that may be closed by this pull request
Enhance component versioning and standard build support #35
Closed
@Ulrond
Copy link

Ulrond commented May 16, 2024

ok you've been added to the project so you should be able to create a branch, but why is this change being added to this repo?

Ulrond
Ulrond reviewed May 16, 2024
View reviewed changes
Copy link

@Ulrond Ulrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please arrange a call to discuss this.

Headerfiles are not fixed location, and they do not specify an included dir.

it's upto the project manifest and the .bb file to set the project requirements not this header file.

@Ulrond Ulrond changed the title RDKE-41 Enhance component versioning and standard build support PR: RDKE-41 Enhance component versioning and standard build support May 16, 2024
Ulrond
Ulrond suggested changes May 16, 2024
View reviewed changes
Copy link

@Ulrond Ulrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not something that should be committed to the header file.

@Ulrond Ulrond added the invalid This doesn't seem right label May 16, 2024
@arun-madhavan-013 arun-madhavan-013 mentioned this pull request Dec 24, 2024
Closed
@arun-madhavan-013 arun-madhavan-013 deleted the develop branch December 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ulrond Ulrond Ulrond requested changes

Assignees

@arun-madhavan-013 arun-madhavan-013

Labels
bug Something isn't working invalid This doesn't seem right
Projects
HAL Interface - Upgrades
Status: Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance component versioning and standard build support
3 participants
@arun-madhavan-013 @hari22yuva @Ulrond