Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial Logging in separate thread #20

Open
barbourshop opened this issue Mar 26, 2024 · 1 comment
Open

Serial Logging in separate thread #20

barbourshop opened this issue Mar 26, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@barbourshop
Copy link

barbourshop commented Mar 26, 2024

Goal: To have all serial logged to a separate file while tests are running

The problem:

Currently, serial output is only logged to the serial.log file when the serial module's read and write functions are called. This means all the output in-between serial actions is lost. This information could be useful in debugging issues when tests show failures.

The solution:

Having the serial module spawn a separate thread for its logging when the test is started (and serial is listed in the config). All output read through the serial console should be written into the serial.log file. With the serial module being updated to have all its read methods read from the serial.log file instead of actually reading from the serial console directly.

Bonus task:

Add timestamps to the serial output as it's logged into the serial.log file.

Acceptance Criteria:

  • All serial console output will be logged to a file while a test is running.
@Ulrond
Copy link
Collaborator

Ulrond commented Oct 1, 2024

we should have a class that supports logging, no matter what console class it is... Therefore any class can support logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants