From 8f726bc9b76d4dede42723914baf7e7fa94e8b40 Mon Sep 17 00:00:00 2001 From: Marcel Fransen Date: Tue, 10 Sep 2024 17:21:40 +0200 Subject: [PATCH 1/5] [doc] TEST DO NOT MERGE!! --- docs/plugin/config.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugin/config.md b/docs/plugin/config.md index ec1c02c819..dbb91fedf6 100644 --- a/docs/plugin/config.md +++ b/docs/plugin/config.md @@ -1,4 +1,4 @@ -In addition to the global Thunder config file (see [here](../introduction/config.md) for more details), each plugin has its own configuration file. +TestTestTest In addition to the global Thunder config file (see [here](../introduction/config.md) for more details), each plugin has its own configuration file. This file contains some generic information about the plugin (name of the library, callsign, execution mode etc), but can easily be extended by developers to include their own options. Using this method for configuring plugins ensures consistency between plugins - there is therefore a single place to configure all plugins. From 89b52b8d305f77a3a98ae3ba926ae37944236919 Mon Sep 17 00:00:00 2001 From: Marcel Fransen Date: Tue, 10 Sep 2024 17:26:09 +0200 Subject: [PATCH 2/5] [doc] TEST DO NO COMMIT --- docs/plugin/composite.md | 9 +++++++++ docs/utils/singletons.md | 3 +++ 2 files changed, 12 insertions(+) diff --git a/docs/plugin/composite.md b/docs/plugin/composite.md index e69de29bb2..428d327c0b 100644 --- a/docs/plugin/composite.md +++ b/docs/plugin/composite.md @@ -0,0 +1,9 @@ +hdsjkdsaHsdjhksdlhsdak +hjksdahsdak + + +sdajdskaljdsA +SJDHAKSDAHL + + +DSAHJKSADH diff --git a/docs/utils/singletons.md b/docs/utils/singletons.md index 19240d936b..52e31d158d 100644 --- a/docs/utils/singletons.md +++ b/docs/utils/singletons.md @@ -1,4 +1,7 @@ ## What is singleton and why it is used + +Hallo Hallo + The Singleton pattern is a design pattern that restricts the instantiation of a class to a single instance. It ensures that only one instance of the class exists throughout the runtime of the program and provides a global point of access to that instance. In addition, they allow for lazy allocation and initialization, whereas global variables will always consume resources. Examples of using singletons can be found in ThunderClientLibraries repository. ## Singleton and SingletonType From 55bf8c6e6339a709d3d79cc4f8894f87c4f2e1d5 Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Wed, 11 Sep 2024 10:31:01 +0200 Subject: [PATCH 3/5] FIrst let's check if the pr number carrying file is properly created --- .github/workflows/Build Documentation Preview.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Build Documentation Preview.yml b/.github/workflows/Build Documentation Preview.yml index b989ffbb3f..c32e63f788 100644 --- a/.github/workflows/Build Documentation Preview.yml +++ b/.github/workflows/Build Documentation Preview.yml @@ -31,6 +31,7 @@ jobs: - run: pip install mkdocs-material - run: mkdocs build - run: echo "${{ github.event.number }}" >> ./site/.pr_number + - run: ls -la ./site - name : Upload preview site artifact uses : actions/upload-artifact@v4 with: From 752e4ef3f705a2468f506e0ef194f1e95466d95e Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Wed, 11 Sep 2024 10:35:14 +0200 Subject: [PATCH 4/5] Make sure the pr number file is not treated as a hidden file --- .github/workflows/Build Documentation Preview.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Build Documentation Preview.yml b/.github/workflows/Build Documentation Preview.yml index c32e63f788..5caac0b35e 100644 --- a/.github/workflows/Build Documentation Preview.yml +++ b/.github/workflows/Build Documentation Preview.yml @@ -30,7 +30,7 @@ jobs: python-version: 3.x - run: pip install mkdocs-material - run: mkdocs build - - run: echo "${{ github.event.number }}" >> ./site/.pr_number + - run: echo "${{ github.event.number }}" >> ./site/pr_number - run: ls -la ./site - name : Upload preview site artifact uses : actions/upload-artifact@v4 @@ -43,7 +43,7 @@ jobs: runs-on: ubuntu-latest steps: - run: mkdir pr_tmp - - run: echo "${{ github.event.number }}" >> ./pr_tmp/.pr_number + - run: echo "${{ github.event.number }}" >> ./pr_tmp/pr_number - uses : actions/upload-artifact@v4 with: name: closed_pr_number From 1dcc2fff964bb285025676e6e87c9457f8fc9b21 Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Wed, 11 Sep 2024 10:35:54 +0200 Subject: [PATCH 5/5] Make sure the pr number file name is properly allignt with the deployment workflow --- .github/workflows/Deploy Documentation Preview.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Deploy Documentation Preview.yml b/.github/workflows/Deploy Documentation Preview.yml index 85e97cf37f..50ade94a32 100644 --- a/.github/workflows/Deploy Documentation Preview.yml +++ b/.github/workflows/Deploy Documentation Preview.yml @@ -42,11 +42,11 @@ jobs: # Get PR number - if: ${{ env.mode == 'deploy' }} name: Get PR number (deploy) - run: echo "pr_number=$(cat ./artifacts/preview_site/.pr_number)" >> "$GITHUB_ENV" + run: echo "pr_number=$(cat ./artifacts/preview_site/pr_number)" >> "$GITHUB_ENV" - if: ${{ env.mode == 'clean' }} name: Get PR number (clean) - run: echo "pr_number=$(cat ./artifacts/closed_pr_number/.pr_number)" >> "$GITHUB_ENV" + run: echo "pr_number=$(cat ./artifacts/closed_pr_number/pr_number)" >> "$GITHUB_ENV" # Run deployment - if: ${{ env.mode == 'deploy' }}