Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable validity for each announcement #24

Open
mahendrapaipuri opened this issue Dec 20, 2022 · 1 comment
Open

Configurable validity for each announcement #24

mahendrapaipuri opened this issue Dec 20, 2022 · 1 comment

Comments

@mahendrapaipuri
Copy link

Hello,

Firstly, thanks a lot for this project. It is quite useful and we are using it in our JupyterHub deployment.

In a typical scenario where admins would like to announce, say maintenance of JupyterHub, after the maintenance, ideally we would like to have announcement disappeared. Currently, we will have to add an empty announcement to make it disappear (I guess?). How about adding a validity for each announcement and the announcement will be automatically purged after it reaches its validity. If admin does not provide a validity for a given announcement, we use the default lifetime_days to get a default validity?

We did something like this for our deployment. Is it something you would be interested to add to the project? If so, I can put up a PR.

Cheers!

@rcthomas
Copy link
Owner

rcthomas commented Jan 3, 2023

Sure, if you're willing to put together a PR, I'll take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants