Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #140

Open
6 tasks
xxchan opened this issue Aug 10, 2020 · 0 comments
Open
6 tasks

Some improvements #140

xxchan opened this issue Aug 10, 2020 · 0 comments

Comments

@xxchan
Copy link
Contributor

xxchan commented Aug 10, 2020

Originally posted by @wangrunji0408 in #120 (comment)

Timer

  • Remove (or implement?) Slack.

Port

  • Make struct fields in port_packet private if possible.

  • Interrupt::bind() should validate port.can_bind_to_interrupt().

Futex

  • For syscall layer, use proc.get_futex() only.

Waker

  • update the Waker every time the future is polled

EventPair

When you get an object which is known to be a EventPair, its peer should be the same type intuitively.

  • Then Socket, Channel, Fifo should also have a fn peer(&self) -> ZxResult<Arc<Self>>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant