Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore multi-version support in BeatUpClient #11

Open
rcelyte opened this issue Aug 25, 2023 · 0 comments
Open

Restore multi-version support in BeatUpClient #11

rcelyte opened this issue Aug 25, 2023 · 0 comments
Labels
mod Involves BeatUpClient regression Something stopped working

Comments

@rcelyte
Copy link
Owner

rcelyte commented Aug 25, 2023

BeatUpClient 0.6.0 included incompatible changes to facilitate Beat Saber 1.31.0 support. The server will need to continue providing protocol support for legacy BeatUpClient versions until an updated mod is available for all game versions 1.20.0+

  • A more modular architecture would enable BeatUpClient to apply sets of patches conditionally depending on game version, as well as providing a path forward for porting to Quest one component at a time
    • Modularity will also improve general maintainability and debuggability in the long run
  • Moving away from C♯-exclusives (delegates, Harmony, etc.) may improve performance moderately and ease development of the Quest mod (BeatUpClient's Detour interface is an example of this, mimicing the beatsaber-hook core mod)
  • The BeatUpClient protocol desperately needs a rework (especially player->player downloads)
@rcelyte rcelyte added the regression Something stopped working label Aug 25, 2023
@rcelyte rcelyte pinned this issue Aug 25, 2023
@rcelyte rcelyte added the mod Involves BeatUpClient label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod Involves BeatUpClient regression Something stopped working
Projects
None yet
Development

No branches or pull requests

1 participant