Add supoport for OSA deployment_environment_variables setting

[BjoernT]

Please add playbook support for deployment_environment_variables as we use that OSA override where necessary

- hosts: xxxx
  environment: "{{ deployment_environment_variables | default({}) }}"```

[antonym]

Do you need this in the incremental playbooks that run or do they need to be passed into the run-upgrade script when called?

The upstream scripts should call this in OSA, just wondering where specifically we need to loop this in.

[BjoernT]

The run-upgrade script should just call playbooks which already should honor these. We need these overrides on all playbooks/tasks which do pip and apt installs

[antonym]

https://gitlab.com/rpco-eng/rpc-upgrades/merge_requests/20/diffs

Just need incremental playbooks?

[BjoernT]

Please merge all code here as no one is looking at gitlab until we physically move the project.
And yes just the incremental playbooks for now. I don't recall the specific task which failed but it should be easily one around pip/apt

[antonym]

Are you good if I mirror the gitlab repo to github and put notations about where to submit issues? There's not really much testing on github at this point...

[BjoernT]

I would be ok with that if there is a concerted move to gitlab, for all new projects for example. Otherwise we have another audit problem etc.