Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect non-test class name resolve causes the command to fail to run #165

Open
asmodeus812 opened this issue Oct 29, 2024 · 1 comment

Comments

@asmodeus812
Copy link

asmodeus812 commented Oct 29, 2024

There is an issue with a recent change to the way the test files are resolved here - https://github.com/rcasia/neotest-java/blob/main/lua/neotest-java/util/resolve_qualified_name.lua#L57. The name can be empty, ending up with the final command containing only the package name, in the final comman i can see that for the TestConfiguration files, instead of a full entry now the command is filled with something like that -c=com.package.name. since if the file is a non-test file, the name is empty string, the entire entry should be skipped from the final command imo.

@asmodeus812
Copy link
Author

One more thing, for some reason in the neotest tree, one still sees the non-test files, such as the test Configruration and utility classes, not sure if that is desireable at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant