Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general2.c:2308: bad condition ? #90

Open
dcb314 opened this issue Nov 27, 2019 · 0 comments
Open

general2.c:2308: bad condition ? #90

dcb314 opened this issue Nov 27, 2019 · 0 comments

Comments

@dcb314
Copy link

dcb314 commented Nov 27, 2019

general2.c:2308:28: warning: logical 'and' of mutually exclusive tests is
always false [-Wlogical-op]

Source code is

if(utf16[2] < 0xdc && utf16[2] > 0xdf)

maybe better code:

if(utf16[2] < 0xdc || utf16[2] > 0xdf)
Fish-Git added a commit to SDL-Hercules-390/hyperion that referenced this issue Nov 28, 2019
@Fish-Git
Fix some bugs caught by gcc:
411bc94 
"warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]"

Reported by dcb314 in SpinHawk issues:

  rbowler/spinhawk#90
  rbowler/spinhawk#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcb314