fix(blade-old): remove unnecessary warning for Checkbox props (#546)

razorpay · Jul 20, 2022 · 576793f · 576793f
1 parent fef2735
commit 576793f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/early-mayflies-retire.md b/.changeset/early-mayflies-retire.md
@@ -0,0 +1,5 @@
+---
+"@razorpay/blade-old": patch
+---
+
+fix(checkbox): remove unnecessary warning for checkbox props
diff --git a/packages/blade-old/src/atoms/Checkbox/Checkbox.native.js b/packages/blade-old/src/atoms/Checkbox/Checkbox.native.js
@@ -228,7 +228,7 @@ Checkbox.propTypes = {
   onChange: PropTypes.func.isRequired,
   testID: PropTypes.string,
   helpText: (props, propName, componentName) => {
-    if (props.size === 'small') {
+    if (props.size === 'small' && props.helpText !== '') {
       return new Error(
         `[${propName}]. ${propName} is ignored as it is not supported when size is small in ${componentName}`,
       );
@@ -243,7 +243,7 @@ Checkbox.propTypes = {
     return null;
   },
   errorText: (props, propName, componentName) => {
-    if (props.size === 'small') {
+    if (props.size === 'small' && props.errorText !== '') {
       return new Error(
         `[${propName}]. ${propName} is ignored as it is not supported when size is small in ${componentName}`,
       );

diff --git a/packages/blade-old/src/atoms/Checkbox/Checkbox.web.js b/packages/blade-old/src/atoms/Checkbox/Checkbox.web.js
@@ -277,7 +277,7 @@ Checkbox.propTypes = {
   id: PropTypes.string,
   name: PropTypes.string,
   helpText: (props, propName, componentName) => {
-    if (props.size === 'small') {
+    if (props.size === 'small' && props.helpText !== '') {
       return new Error(
         `[${propName}]. ${propName} is ignored as it is not supported when size is small in ${componentName}`,
       );
@@ -292,7 +292,7 @@ Checkbox.propTypes = {
     return null;
   },
   errorText: (props, propName, componentName) => {
-    if (props.size === 'small') {
+    if (props.size === 'small' && props.errorText !== '') {
       return new Error(
         `[${propName}]. ${propName} is ignored as it is not supported when size is small in ${componentName}`,
       );