[Grafana] Removes legends label {{replica}} for serve_deoloyment_dashboard for better observability
#49933
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter observability Signed-off-by: win5923 <[email protected]>
|
@MengjinYan @alanwguo PTAL |
win5923
changed the title
serve_deoloyment_dashboard for tter observability{{replica}} for serve_deoloyment_dashboard for tter observability
win5923
changed the title
{{replica}} for serve_deoloyment_dashboard for tter observability{{replica}} for serve_deoloyment_dashboard for better observability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In the latest version, the
{{replicas}}legend label for some panels in Serve Deployment Dashboard only displays the hash value of the replica (e.g., az01tht6), whereas in version 2.9.0, it included the full replica information (e.g., math_app#Router#VzsBpw). This will makes it more difficult to interpret metrics as the full replica information is no longer displayed for new version.version nightly:
version 2.9.0:
Before this PR (version: nightly):
After this PR (version: nightly):
Related issue number
Closes #49851
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.