Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --profile:build option #10

Closed
allenli873 opened this issue Nov 26, 2024 · 4 comments · Fixed by #11
Closed

Add --profile:build option #10

allenli873 opened this issue Nov 26, 2024 · 4 comments · Fixed by #11

Comments

@allenli873
Copy link
Contributor

Currently, there's only the option to specify --profile, which is equivalent to --profile:host (source). Would it be possible to expose a way to specify --profile:build?
@ravenexp
Copy link
Owner

ravenexp commented Nov 27, 2024 •
edited
Loading

Yes, I'll add ConanInstall::build_profile() and also ConanInstall::host_profile() as an alias for ConanInstall::profile().

@ravenexp
Copy link
Owner

You can look at a draft implementation in #11.

ravenexp added a commit that referenced this issue Nov 27, 2024
@ravenexp
feat: Add ConanInstall::build_profile() method
68768dd 
Allow setting Conan build profile along with the host profile.

Add an alias `ConanInstall::host_profile()` for `ConanInstall::profile()`.

Bump the crate version to 0.1.3 (preliminary).

Resolves #10
@ravenexp ravenexp mentioned this issue Nov 27, 2024
Merged
@allenli873
Copy link
Contributor Author

Change LGTM and works for me on my end, thank you very much! There's also option profile:all which sets both if you could expose that as well, but definitely not strictly necessary.

ravenexp added a commit that referenced this issue Nov 27, 2024
@ravenexp
feat: Add ConanInstall::build_profile() method
f1e4cd6 
Allow setting Conan build profile along with the host profile.

Add an alias `ConanInstall::host_profile()` for `ConanInstall::profile()`.

Bump the crate version to 0.1.3 (preliminary).

Resolves #10
@ravenexp
Copy link
Owner

Released in v0.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ConanInstall::build_profile() method ravenexp/conan2-rs
2 participants
@ravenexp @allenli873