-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Add a Are you sure you would like to write to? #905
Comments
Thanks for the report, @kdsands88 I can see some solid user experience improvements we could add as cues:
I've just checked our DriveList dependency, and it looks like this functionality is not a straightforward addition - Drivelist is not obtaining the volume label* today, so we'll need to teach it how to. Feature request accepted. |
balena-io-modules/drivelist#123 and balena-io-modules/drivelist#323 and balena-io-modules/drivelist#402 😉 |
I'm not surprised that this hasn't been implemented - it's conceptually complicated. At the media selection level, we're looking to select a physical device, but on on any physical device there may be multiple volumes. The volumes have labels. By convention, Windows didn't expose partitioning on SD cards or USB drives, so you would generally expect a SD card or USB drive to have a single volume filling the entire device. That's not the case after you've used Imager, though - we write a full disk image with at least two volumes. In exposing this function in Imager, I'll need to be careful to capture not just the first volume, but any volumes that might be affected. Interestingly, on Linux we probably get the volume names already - as these are encoded in the mount points, which Drivelist does get today. macOS behaves similarly - so it's just Windows, which uses the lossy Drive Letter assignment, that doesn't get the full details. |
Drivelist already provides a mountpointLabels vector ready for someone to toss all volumes you find on that disk in. So don't see the complication. |
Is your feature request related to a problem? Please describe.
Issue: Raspberry Pi Imager wrote an SD image to an external USB storage drive not the SD card reader.
Describe the solution you would like to see implemented
Request: If I was given a question "Are you sure you would want to write to XXX with XXX amount of data?" I would have seen I choose the wrong drive.
Describe alternatives you've considered
Also, Raspberry Pi Imager only shows the drive letter not the drive name. If it show "you would want to write to Personal Data" and not "E:" I would have know I was writing to the wrong drive!!!!
Additional context
Raspberry Pi Imager currently makes it hard to indentify which drive I am writing to. I only use this software once every 2 years.
Version
1.8.5 (Default)
The text was updated successfully, but these errors were encountered: