Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Check if otel-cli exists before calling it #25

Open
bdice opened this issue Nov 14, 2024 · 0 comments
Open

Telemetry: Check if otel-cli exists before calling it #25

bdice opened this issue Nov 14, 2024 · 0 comments

Comments

@bdice
Copy link
Contributor

bdice commented Nov 14, 2024

if ! otel-cli --help 2>&1 >/dev/null; then

We should probably use something like

if ! command -v otel-cli 2>&1 >/dev/null

to check if the command exists first. Otherwise we get log output like

/home/runner/work/_temp/4bb311e7-86b2-4596-8ba4-3c1572bb63be.sh: line 1: otel-cli: command not found
@bdice bdice changed the title Check if otel-cli exists before calling it Telemetry: Check if otel-cli exists before calling it Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant