Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Running nvcomp tests in an environment with nvcomp already present fails #725

Open
vyasr opened this issue Dec 4, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@vyasr
Copy link
Contributor

vyasr commented Dec 4, 2024

The way that we fill the CPM cache with nvcomp during testing does not work properly if nvcomp is already installed on the host system. The problem is that since we don't actually use the CPM cache to establish nvcomp source but rather download a binary directly (because official nvcomp releases are binary-only, the project isn't open-source), and to avoid redundant downloads we handle this internally by searching for nvcomp packages directly within rapids_cpm_nvcomp before we download the binary. As a result, if nvcomp is already installed the download doesn't happen when populating the cache. Moreover, when later tests are run that invoke rapids_cpm_nvcomp the same logic leads to the local copy being found first, so even if the cache were populated it would have no effect on what is found. To fix this we would have to use a custom override.json to ensure the download and propagate the associated nvcomp root through to all the tests. This is doable, but it is a lot of effort for handling an edge case (testing in environments where nvcomp is installed) so I wouldn't prioritize fixing this anytime soon.

@vyasr vyasr added ? - Needs Triage Need team to review and classify bug Something isn't working labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant