Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pinned dependency versions file references patches with the wrong path #718

Open
jlowe opened this issue Nov 13, 2024 · 0 comments
Open
Labels
2 - In Progress Currenty a work in progress bug Something isn't working

Comments

@jlowe
Copy link
Member

jlowe commented Nov 13, 2024

Describe the bug
The generated json file for pinning dependencies for a reproducible build can reference patch files with an incorrect path.
When the build attempts to reference the patch files with the incorrect paths and fails to find them, the build does not fail.

Steps/Code to reproduce bug

Note that when libcudf is configured during the build, cmake complains about a failure to locate patch files for CCCL, but the build does not fail. See NVIDIA/spark-rapids-jni#2582 for details.

Expected behavior

  • The generated dependency version json has valid paths to any patch files required for the dependency.
  • The build should fail if requested patch files are not found.
@jlowe jlowe added ? - Needs Triage Need team to review and classify bug Something isn't working labels Nov 13, 2024
@robertmaynard robertmaynard added 2 - In Progress Currenty a work in progress and removed ? - Needs Triage Need team to review and classify labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants